SpotBugs Report

Project Information

Project:

SpotBugs version: 4.9.3

Code analyzed:

/home/runner/work/VStar/VStar/dist/vstar.jar

Metrics

32806 lines of code analyzed, in 804 classes, in 55 packages.

Metric	Total	Density*
High Priority Warnings	58	1.77
Medium Priority Warnings	564	17.19
Total Warnings	622	18.96

(* Defects per Thousand lines of non-commenting source statements)

Bad practice Warnings
Correctness Warnings
Experimental Warnings
Internationalization Warnings
Malicious code vulnerability Warnings
Multithreaded correctness Warnings
Performance Warnings
Dodgy code Warnings
Details

Summary

Warning Type	Number
Bad practice Warnings	65
Correctness Warnings	21
Experimental Warnings	1
Internationalization Warnings	19
Malicious code vulnerability Warnings	357
Multithreaded correctness Warnings	24
Performance Warnings	45
Dodgy code Warnings	90
Total	622

Warnings

Click on a warning row to see full context information.

Bad practice Warnings

Code	Warning
CT	Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) At AbstractObservationFieldMatcher.java:[line 62] At AbstractObservationFieldMatcher.java:[line 62]
CT	Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(ObservationMatcherOp[]) At AbstractObservationFieldMatcher.java:[line 73] At AbstractObservationFieldMatcher.java:[line 73]
CT	Exception thrown in class org.aavso.tools.vstar.data.validation.CKMagValidator at new org.aavso.tools.vstar.data.validation.CKMagValidator(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.data.validation.CKMagValidator In method new org.aavso.tools.vstar.data.validation.CKMagValidator(String) At CKMagValidator.java:[line 41] At CKMagValidator.java:[line 41]
CT	Exception thrown in class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase at new org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method new org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase(String, String) At AIDWebServiceObservationSourcePluginBase.java:[line 62] At AIDWebServiceObservationSourcePluginBase.java:[line 62]
CT	Exception thrown in class org.aavso.tools.vstar.ui.NumberSelectionPane at new org.aavso.tools.vstar.ui.NumberSelectionPane(String, double, double, double, double, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.NumberSelectionPane In method new org.aavso.tools.vstar.ui.NumberSelectionPane(String, double, double, double, double, String) At NumberSelectionPane.java:[line 69] At NumberSelectionPane.java:[line 69]
CT	Exception thrown in class org.aavso.tools.vstar.ui.dialog.DateToJdDialog at new org.aavso.tools.vstar.ui.dialog.DateToJdDialog(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.dialog.DateToJdDialog In method new org.aavso.tools.vstar.ui.dialog.DateToJdDialog(String) At DateToJdDialog.java:[line 73] At DateToJdDialog.java:[line 73]
CT	Exception thrown in class org.aavso.tools.vstar.ui.dialog.LogDialog at new org.aavso.tools.vstar.ui.dialog.LogDialog() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.dialog.LogDialog In method new org.aavso.tools.vstar.ui.dialog.LogDialog() At LogDialog.java:[line 65] At LogDialog.java:[line 65]
CT	Exception thrown in class org.aavso.tools.vstar.ui.dialog.StarSelectorDialog at new org.aavso.tools.vstar.ui.dialog.StarSelectorDialog() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.dialog.StarSelectorDialog In method new org.aavso.tools.vstar.ui.dialog.StarSelectorDialog() At StarSelectorDialog.java:[line 131] At StarSelectorDialog.java:[line 131]
CT	Exception thrown in class org.aavso.tools.vstar.ui.dialog.TextAreaTabs at new org.aavso.tools.vstar.ui.dialog.TextAreaTabs(List, List, int, int, boolean, boolean, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.dialog.TextAreaTabs In method new org.aavso.tools.vstar.ui.dialog.TextAreaTabs(List, List, int, int, boolean, boolean, String) At TextAreaTabs.java:[line 59] At TextAreaTabs.java:[line 59]
CT	Exception thrown in class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog at new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog(String, String, IPeriodAnalysisAlgorithm, PeriodAnalysisCoordinateType[], PeriodAnalysisCoordinateType) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog In method new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DResultDialog(String, String, IPeriodAnalysisAlgorithm, PeriodAnalysisCoordinateType[], PeriodAnalysisCoordinateType) At PeriodAnalysis2DResultDialog.java:[line 108] At PeriodAnalysis2DResultDialog.java:[line 108]
CT	Exception thrown in class org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel at new org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel(List, SeriesType) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel In method new org.aavso.tools.vstar.ui.model.list.AbstractModelObservationTableModel(List, SeriesType) At AbstractModelObservationTableModel.java:[line 43] At AbstractModelObservationTableModel.java:[line 43]
CT	Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) At ObservationAndMeanPlotModel.java:[line 112] At ObservationAndMeanPlotModel.java:[line 112]
CT	Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) At ObservationPlotModel.java:[line 170] At ObservationPlotModel.java:[line 170]
CT	Exception thrown in class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel at new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) At ObservationPlotModel.java:[line 228] At ObservationPlotModel.java:[line 228]
CT	Exception thrown in class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel at new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel In method new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) At PeriodAnalysis2DPlotModel.java:[line 65] At PeriodAnalysis2DPlotModel.java:[line 65]
CT	Exception thrown in class org.aavso.tools.vstar.ui.resources.StarGroups at new org.aavso.tools.vstar.ui.resources.StarGroups() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method new org.aavso.tools.vstar.ui.resources.StarGroups() At StarGroups.java:[line 65] At StarGroups.java:[line 65]
CT	Exception thrown in class org.aavso.tools.vstar.util.discrepant.DiscrepantReport at new org.aavso.tools.vstar.util.discrepant.DiscrepantReport(String, String, int, String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.discrepant.DiscrepantReport In method new org.aavso.tools.vstar.util.discrepant.DiscrepantReport(String, String, int, String, String) At DiscrepantReport.java:[line 62] At DiscrepantReport.java:[line 62]
CT	Exception thrown in class org.aavso.tools.vstar.util.model.Harmonic at new org.aavso.tools.vstar.util.model.Harmonic(double) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.model.Harmonic In method new org.aavso.tools.vstar.util.model.Harmonic(double) At Harmonic.java:[line 64] At Harmonic.java:[line 64]
CT	Exception thrown in class org.aavso.tools.vstar.util.model.Harmonic at new org.aavso.tools.vstar.util.model.Harmonic(double, int) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.model.Harmonic In method new org.aavso.tools.vstar.util.model.Harmonic(double, int) At Harmonic.java:[line 44] At Harmonic.java:[line 44]
CT	Exception thrown in class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator at new org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator(List) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator In method new org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator(List) At RelativeAmplitudeAndPhaseCreator.java:[line 52] At RelativeAmplitudeAndPhaseCreator.java:[line 52]
CT	Exception thrown in class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint at new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(double[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(double[]) At PeriodAnalysisDataPoint.java:[line 59] At PeriodAnalysisDataPoint.java:[line 59]
CT	Exception thrown in class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint at new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) At PeriodAnalysisDataPoint.java:[line 52] At PeriodAnalysisDataPoint.java:[line 52]
CT	Exception thrown in class org.aavso.tools.vstar.util.property.ApplicationProperties at new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.util.property.ApplicationProperties In method new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) At ApplicationProperties.java:[line 83] At ApplicationProperties.java:[line 83]
CT	Exception thrown in class org.aavso.tools.vstar.vela.VeLaInterpreter at new org.aavso.tools.vstar.vela.VeLaInterpreter() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method new org.aavso.tools.vstar.vela.VeLaInterpreter() At VeLaInterpreter.java:[line 150] At VeLaInterpreter.java:[line 150]
CT	Exception thrown in class org.aavso.tools.vstar.vela.VeLaInterpreter at new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean) At VeLaInterpreter.java:[line 142] At VeLaInterpreter.java:[line 142]
CT	Exception thrown in class org.aavso.tools.vstar.vela.VeLaInterpreter at new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean, boolean, List) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
	Bug type CT_CONSTRUCTOR_THROW (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean, boolean, List) At VeLaInterpreter.java:[line 113] At VeLaInterpreter.java:[line 113]
Co	org.aavso.tools.vstar.util.model.Harmonic.compareTo(Harmonic) incorrectly handles double value
	Bug type CO_COMPARETO_INCORRECT_FLOATING (click for details) In class org.aavso.tools.vstar.util.model.Harmonic In method org.aavso.tools.vstar.util.model.Harmonic.compareTo(Harmonic) Type double Should call Double.compare(double, double) instead Return value of org.aavso.tools.vstar.util.model.Harmonic.getFrequency() of type double Value loaded from field org.aavso.tools.vstar.util.model.Harmonic.frequency At Harmonic.java:[line 135]
DE	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.updateChartProperties() might ignore java.lang.Exception
	Bug type DE_MIGHT_IGNORE (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.updateChartProperties() Exception class java.lang.Exception At AbstractObservationPlotPane.java:[line 396] At AbstractObservationPlotPane.java:[line 396]
Dm	org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons() invokes System.exit(...), which shuts down the entire virtual machine
	Bug type DM_EXIT (click for details) In class org.aavso.tools.vstar.ui.ToolBar In method org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons() At ToolBar.java:[line 231]
Dm	org.aavso.tools.vstar.ui.VStar$4.run() invokes System.exit(...), which shuts down the entire virtual machine
	Bug type DM_EXIT (click for details) In class org.aavso.tools.vstar.ui.VStar$4 In method org.aavso.tools.vstar.ui.VStar$4.run() At VStar.java:[line 199]
Dm	org.aavso.tools.vstar.ui.mediator.Mediator.quit() invokes System.exit(...), which shuts down the entire virtual machine
	Bug type DM_EXIT (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.quit() At Mediator.java:[line 2374]
Dm	org.aavso.tools.vstar.util.property.ApplicationProperties.update() invokes System.exit(...), which shuts down the entire virtual machine
	Bug type DM_EXIT (click for details) In class org.aavso.tools.vstar.util.property.ApplicationProperties In method org.aavso.tools.vstar.util.property.ApplicationProperties.update() At ApplicationProperties.java:[line 154]
Dm	org.aavso.tools.vstar.vela.VeLaInterpreter$5.apply(List) invokes System.exit(...), which shuts down the entire virtual machine
	Bug type DM_EXIT (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter$5 In method org.aavso.tools.vstar.vela.VeLaInterpreter$5.apply(List) At VeLaInterpreter.java:[line 1570]
ES	Comparison of String parameter using == or != in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)
	Bug type ES_COMPARING_PARAMETER_STRING_WITH_EQ (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String) Actual type String String constant "DIFF" Value loaded from mtypeStr At AIDWebServiceObservationSourcePluginBase.java:[line 402]
ES	Comparison of String parameter using == or != in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)
	Bug type ES_COMPARING_PARAMETER_STRING_WITH_EQ (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String) Actual type String String constant "STEP" Value loaded from mtypeStr At AIDWebServiceObservationSourcePluginBase.java:[line 404]
ES	Comparison of String objects using == or != in org.aavso.tools.vstar.util.TSBase.project()
	Bug type ES_COMPARING_STRINGS_WITH_EQ (click for details) In class org.aavso.tools.vstar.util.TSBase In method org.aavso.tools.vstar.util.TSBase.project() Actual type String At TSBase.java:[line 448]
ES	Comparison of String objects using == or != in org.aavso.tools.vstar.util.model.TSPolynomialFitter.polymast(int)
	Bug type ES_COMPARING_STRINGS_WITH_EQ (click for details) In class org.aavso.tools.vstar.util.model.TSPolynomialFitter In method org.aavso.tools.vstar.util.model.TSPolynomialFitter.polymast(int) Actual type String At TSPolynomialFitter.java:[line 236]
ES	Comparison of String objects using == or != in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel)
	Bug type ES_COMPARING_STRINGS_WITH_EQ (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel) Actual type String At TSDcDft.java:[line 938]
Eq	org.aavso.tools.vstar.util.model.Harmonic defines compareTo(Harmonic) and uses Object.equals()
	Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) In class org.aavso.tools.vstar.util.model.Harmonic In method org.aavso.tools.vstar.util.model.Harmonic.compareTo(Harmonic) At Harmonic.java:[lines 131-139]
FS	Format string should use %n rather than \n in org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.toUncertaintyString()
	Bug type VA_FORMAT_STRING_USES_NEWLINE (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.toUncertaintyString() Called method String.format(String, Object[]) Format string "For frequency %s, period %s, power %s, semi-amplitude %s:\n\n" At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 208]
HE	org.aavso.tools.vstar.util.model.PeriodFitParameters defines equals and uses Object.hashCode()
	Bug type HE_EQUALS_USE_HASHCODE (click for details) In class org.aavso.tools.vstar.util.model.PeriodFitParameters In method org.aavso.tools.vstar.util.model.PeriodFitParameters.equals(Object) At PeriodFitParameters.java:[lines 189-203]
HE	org.aavso.tools.vstar.util.period.wwz.WWZStatistic defines equals and uses Object.hashCode()
	Bug type HE_EQUALS_USE_HASHCODE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WWZStatistic In method org.aavso.tools.vstar.util.period.wwz.WWZStatistic.equals(Object) At WWZStatistic.java:[lines 140-148]
ME	org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher$Kind.name field is public and mutable
	Bug type ME_MUTABLE_ENUM_FIELD (click for details) In class org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher$Kind Field org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher$Kind.name In SeriesTypeFieldMatcher.java
NP	org.aavso.tools.vstar.data.filter.ObservationMatcherOp.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.data.filter.ObservationMatcherOp In method org.aavso.tools.vstar.data.filter.ObservationMatcherOp.toString() Value loaded from s Returned at ObservationMatcherOp.java:[line 92] Null value at ObservationMatcherOp.java:[line 66] Known null at ObservationMatcherOp.java:[line 68]
NP	org.aavso.tools.vstar.plugin.CustomFilterPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.CustomFilterPluginBase In method org.aavso.tools.vstar.plugin.CustomFilterPluginBase.test() At CustomFilterPluginBase.java:[line 164]
NP	org.aavso.tools.vstar.plugin.GeneralToolPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.GeneralToolPluginBase In method org.aavso.tools.vstar.plugin.GeneralToolPluginBase.test() At GeneralToolPluginBase.java:[line 79]
NP	org.aavso.tools.vstar.plugin.ModelCreatorPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.ModelCreatorPluginBase In method org.aavso.tools.vstar.plugin.ModelCreatorPluginBase.test() At ModelCreatorPluginBase.java:[line 106]
NP	org.aavso.tools.vstar.plugin.ObservationSinkPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.ObservationSinkPluginBase In method org.aavso.tools.vstar.plugin.ObservationSinkPluginBase.test() At ObservationSinkPluginBase.java:[line 108]
NP	org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.ObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.test() At ObservationSourcePluginBase.java:[line 341]
NP	org.aavso.tools.vstar.plugin.ObservationToolPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.ObservationToolPluginBase In method org.aavso.tools.vstar.plugin.ObservationToolPluginBase.test() At ObservationToolPluginBase.java:[line 85]
NP	org.aavso.tools.vstar.plugin.ObservationTransformerPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.ObservationTransformerPluginBase In method org.aavso.tools.vstar.plugin.ObservationTransformerPluginBase.test() At ObservationTransformerPluginBase.java:[line 83]
NP	org.aavso.tools.vstar.plugin.period.PeriodAnalysisPluginBase.test() has Boolean return type and returns explicit null
	Bug type NP_BOOLEAN_RETURN_NULL (click for details) In class org.aavso.tools.vstar.plugin.period.PeriodAnalysisPluginBase In method org.aavso.tools.vstar.plugin.period.PeriodAnalysisPluginBase.test() At PeriodAnalysisPluginBase.java:[line 192]
NP	org.aavso.tools.vstar.ui.mediator.message.UndoableActionType.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.UndoableActionType In method org.aavso.tools.vstar.ui.mediator.message.UndoableActionType.toString() Value loaded from str Returned at UndoableActionType.java:[line 60] Null value at UndoableActionType.java:[line 46] Known null at UndoableActionType.java:[line 48]
NP	org.aavso.tools.vstar.ui.resources.LoginType.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.ui.resources.LoginType In method org.aavso.tools.vstar.ui.resources.LoginType.toString() Value loaded from str Returned at LoginType.java:[line 39] Null value at LoginType.java:[line 28] Known null at LoginType.java:[line 30]
NP	org.aavso.tools.vstar.util.AbstractExtremaFinder.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.util.AbstractExtremaFinder In method org.aavso.tools.vstar.util.AbstractExtremaFinder.toString() Constant value null Returned at AbstractExtremaFinder.java:[line 261] Known null at AbstractExtremaFinder.java:[line 261]
NP	org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType In method org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.toString() Value loaded from str Returned at WWZCoordinateType.java:[line 109] Null value at WWZCoordinateType.java:[line 83] Known null at WWZCoordinateType.java:[line 85]
NP	org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs$Type.toString() may return null
	Bug type NP_TOSTRING_COULD_RETURN_NULL (click for details) In class org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs$Type In method org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs$Type.toString() Value loaded from s Returned at NumericPrecisionPrefs.java:[line 48] Null value at NumericPrecisionPrefs.java:[line 36] Known null at NumericPrecisionPrefs.java:[line 37]
Nm	The class name org.aavso.tools.vstar.data.Property$propType doesn't start with an upper case letter
	Bug type NM_CLASS_NAMING_CONVENTION (click for details) In class org.aavso.tools.vstar.data.Property$propType At Property.java:[lines 30-31]
OS	org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever() may fail to close stream
	Bug type OS_OPEN_STREAM (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin In method org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever() Need to close java.io.Reader At TextFormatObservationSourcePlugin.java:[line 91]
RV	Exceptional return value of java.io.File.mkdir() ignored in org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>()
	Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) In class org.aavso.tools.vstar.ui.VStar In method org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>() Called method java.io.File.mkdir() At VStar.java:[line 54]
RV	Exceptional return value of java.io.File.mkdir() ignored in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.installPlugin(String, PluginManager$Operation)
	Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.installPlugin(String, PluginManager$Operation) Called method java.io.File.mkdir() At PluginManager.java:[line 713] Another occurrence at PluginManager.java:[line 736]
RV	org.aavso.tools.vstar.util.comparator.RankedIndexPairComparator.compare(double[], double[]) negates the return value of Double.compare(double, double)
	Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details) In class org.aavso.tools.vstar.util.comparator.RankedIndexPairComparator In method org.aavso.tools.vstar.util.comparator.RankedIndexPairComparator.compare(double[], double[]) Called method Double.compare(double, double) Return value of Double.compare(double, double) of type int At RankedIndexPairComparator.java:[line 37]
Se	org.aavso.tools.vstar.util.stats.epoch.AlphaOmegaMeanJDEpochStrategy stored into non-transient field PhaseParameterDialog.epochStrategy
	Bug type SE_BAD_FIELD_STORE (click for details) In class org.aavso.tools.vstar.ui.dialog.PhaseParameterDialog Field org.aavso.tools.vstar.ui.dialog.PhaseParameterDialog.epochStrategy Actual type org.aavso.tools.vstar.util.stats.epoch.AlphaOmegaMeanJDEpochStrategy At PhaseParameterDialog.java:[line 75]
Se	org.aavso.tools.vstar.util.comparator.DoubleAsStringComparator implements Comparator but not Serializable
	Bug type SE_COMPARATOR_SHOULD_BE_SERIALIZABLE (click for details) In class org.aavso.tools.vstar.util.comparator.DoubleAsStringComparator At DoubleAsStringComparator.java:[lines 27-32]
Se	org.aavso.tools.vstar.util.comparator.DoubleComparator implements Comparator but not Serializable
	Bug type SE_COMPARATOR_SHOULD_BE_SERIALIZABLE (click for details) In class org.aavso.tools.vstar.util.comparator.DoubleComparator At DoubleComparator.java:[lines 25-29]

Correctness Warnings

Code	Warning
EC	Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDescription()
	Bug type EC_UNRELATED_TYPES (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDescription() Actual type String Expected java.util.Locale String constant "es" Value loaded from field org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.locale java.util.Locale.equals(Object) used to determine equality At AAVSOPhotometryURLObservationSourceBase.java:[line 144]
EC	Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDisplayName()
	Bug type EC_UNRELATED_TYPES (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getDisplayName() Actual type String Expected java.util.Locale String constant "es" Value loaded from field org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.locale java.util.Locale.equals(Object) used to determine equality At AAVSOPhotometryURLObservationSourceBase.java:[line 155]
EC	Call to java.util.Locale.equals(String) in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.getSourceType()
	Bug type EC_UNRELATED_TYPES (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.getSourceType() Actual type String Expected java.util.Locale String constant "es" Value loaded from field org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.locale java.util.Locale.equals(Object) used to determine equality At AAVSOPhotometryURLObservationSourceBase.java:[line 326]
FE	Doomed test for equality to NaN in org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane$3.update(PeriodAnalysisSelectionMessage)
	Bug type FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane$3 In method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane$3.update(PeriodAnalysisSelectionMessage) At PeriodAnalysis2DChartPane.java:[line 286]
FE	Doomed test for equality to NaN in org.aavso.tools.vstar.util.model.AbstractModel.fitMetrics()
	Bug type FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER (click for details) In class org.aavso.tools.vstar.util.model.AbstractModel In method org.aavso.tools.vstar.util.model.AbstractModel.fitMetrics() At AbstractModel.java:[line 235] Another occurrence at AbstractModel.java:[line 240]
FL	Using floating-point loop counters can lead to unexpected behavior.
	Bug type FL_FLOATS_AS_LOOP_COUNTERS (click for details) In class org.aavso.tools.vstar.util.model.PeriodFitParameters In method org.aavso.tools.vstar.util.model.PeriodFitParameters.getRelativePhase(double) At PeriodFitParameters.java:[line 136]
IL	There is an apparent infinite loop in org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[])
	Bug type IL_INFINITE_LOOP (click for details) In class org.aavso.tools.vstar.vela.VeLaScriptDriver In method org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[]) At VeLaScriptDriver.java:[line 99] Local variable named restartOnError At VeLaScriptDriver.java:[line 50]
MF	Field ObservationAndMeanPlotModel.modelFunctionSeriesNum masks field in superclass org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel
	Bug type MF_CLASS_MASKS_FIELD (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel Masking field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.modelFunctionSeriesNum Masked field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.modelFunctionSeriesNum In ObservationAndMeanPlotModel.java
NP	Possible null pointer dereference of dcdft in org.aavso.tools.vstar.scripting.VStarScriptingAPI.dcdftCommon(String, DcDftAnalysisType, double, double, double) on exception path
	Bug type NP_NULL_ON_SOME_PATH_EXCEPTION (click for details) In class org.aavso.tools.vstar.scripting.VStarScriptingAPI In method org.aavso.tools.vstar.scripting.VStarScriptingAPI.dcdftCommon(String, DcDftAnalysisType, double, double, double) Value loaded from dcdft Dereferenced at VStarScriptingAPI.java:[line 917] Null value at VStarScriptingAPI.java:[line 897] Known null at VStarScriptingAPI.java:[line 899]
NP	Possible null pointer dereference of obs in org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String)
	Bug type NP_NULL_ON_SOME_PATH (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String) Value loaded from obs Dereferenced at Mediator.java:[line 2070] Null value at Mediator.java:[line 2041] Known null at Mediator.java:[line 2051]
NP	Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getInputFormatString(int, NumericPrecisionPrefs$Type) on exception path
	Bug type NP_NULL_ON_SOME_PATH_EXCEPTION (click for details) In class org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs In method org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getInputFormatString(int, NumericPrecisionPrefs$Type) Value loaded from formats Dereferenced at NumericPrecisionPrefs.java:[line 305] Null value at NumericPrecisionPrefs.java:[line 291] Known null at NumericPrecisionPrefs.java:[line 293]
NP	Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormat(int, NumericPrecisionPrefs$Type) on exception path
	Bug type NP_NULL_ON_SOME_PATH_EXCEPTION (click for details) In class org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs In method org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormat(int, NumericPrecisionPrefs$Type) Value loaded from formats Dereferenced at NumericPrecisionPrefs.java:[line 257] Null value at NumericPrecisionPrefs.java:[line 243] Known null at NumericPrecisionPrefs.java:[line 245]
NP	Possible null pointer dereference of formats in org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormatLocaleIndependent(int, NumericPrecisionPrefs$Type) on exception path
	Bug type NP_NULL_ON_SOME_PATH_EXCEPTION (click for details) In class org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs In method org.aavso.tools.vstar.util.prefs.NumericPrecisionPrefs.getOutputFormatLocaleIndependent(int, NumericPrecisionPrefs$Type) Value loaded from formats Dereferenced at NumericPrecisionPrefs.java:[line 280] Null value at NumericPrecisionPrefs.java:[line 266] Known null at NumericPrecisionPrefs.java:[line 268]
NP	Possible null pointer dereference of reader in org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[]) on exception path
	Bug type NP_NULL_ON_SOME_PATH_EXCEPTION (click for details) In class org.aavso.tools.vstar.vela.VeLaScriptDriver In method org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[]) Value loaded from reader Dereferenced at VeLaScriptDriver.java:[line 102] Null value at VeLaScriptDriver.java:[line 35] Known null at VeLaScriptDriver.java:[line 44]
RCN	Nullcheck of delimiter2suffixes at line 100 of value previously dereferenced in org.aavso.tools.vstar.ui.dialog.DelimitedFieldFileSaveChooser.getSelectedFile()
	Bug type RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE (click for details) In class org.aavso.tools.vstar.ui.dialog.DelimitedFieldFileSaveChooser In method org.aavso.tools.vstar.ui.dialog.DelimitedFieldFileSaveChooser.getSelectedFile() Value loaded from delimiter2suffixes Return value of org.aavso.tools.vstar.plugin.ObservationSinkPluginBase.getDelimiterSuffixValuePairs() of type java.util.Map At DelimitedFieldFileSaveChooser.java:[line 100] Redundant null check at DelimitedFieldFileSaveChooser.java:[line 102]
RpC	Repeated conditional test in org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons()
	Bug type RpC_REPEATED_CONDITIONAL_TEST (click for details) In class org.aavso.tools.vstar.ui.ToolBar In method org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons() At ToolBar.java:[line 216] At ToolBar.java:[line 216]
SING	Class (org.aavso.tools.vstar.scripting.ScriptRunner) using singleton design pattern has non-private constructor.
	Bug type SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR (click for details) In class org.aavso.tools.vstar.scripting.ScriptRunner In method new org.aavso.tools.vstar.scripting.ScriptRunner(boolean) At ScriptRunner.java:[lines 56-65]
SING	Class (org.aavso.tools.vstar.ui.dialog.StarSelectorDialog) using singleton design pattern directly or indirectly implements Serializable interface.
	Bug type SING_SINGLETON_IMPLEMENTS_SERIALIZABLE (click for details) In class org.aavso.tools.vstar.ui.dialog.StarSelectorDialog At StarSelectorDialog.java:[lines 59-676]
SING	Class (org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog) using singleton design pattern directly or indirectly implements Serializable interface.
	Bug type SING_SINGLETON_IMPLEMENTS_SERIALIZABLE (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog At PreferencesDialog.java:[lines 49-139]
SING	Class (org.aavso.tools.vstar.ui.resources.StarGroups) using singleton design pattern has non-private constructor.
	Bug type SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method new org.aavso.tools.vstar.ui.resources.StarGroups() At StarGroups.java:[lines 61-78]
SING	Class (org.aavso.tools.vstar.vela.VeLaStandardLibrary) using singleton design pattern has non-private constructor.
	Bug type SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR (click for details) In class org.aavso.tools.vstar.vela.VeLaStandardLibrary In method new org.aavso.tools.vstar.vela.VeLaStandardLibrary() At VeLaStandardLibrary.java:[line 23]

Experimental Warnings

Code	Warning
OBL	org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.createObservationArtefacts() may fail to clean up java.io.InputStream
	Bug type OBL_UNSATISFIED_OBLIGATION (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.createObservationArtefacts() Reference type java.io.InputStream 1 instances of obligation remaining Obligation to clean up resource created at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 113] is not discharged Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 114] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 117] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 118] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 124] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 128] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 132] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 134] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 139] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 140] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 141] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 140] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 145] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 148] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 168] Path continues at NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 169] Remaining obligations: {InputStream x 1}

Code

Warning

OBL

org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.createObservationArtefacts() may fail to clean up java.io.InputStream

Internationalization Warnings

Code	Warning
Dm	Found reliance on default encoding in org.aavso.tools.vstar.auth.AAVSOPostUserPassXMLAuthenticationSource.authenticate(String, String): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.auth.AAVSOPostUserPassXMLAuthenticationSource In method org.aavso.tools.vstar.auth.AAVSOPostUserPassXMLAuthenticationSource.authenticate(String, String) Called method String.getBytes() At AAVSOPostUserPassXMLAuthenticationSource.java:[line 106]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.auth.Auth0JSONAutheticationSource.authenticate(String, String): new java.io.InputStreamReader(InputStream)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.auth.Auth0JSONAutheticationSource In method org.aavso.tools.vstar.auth.Auth0JSONAutheticationSource.authenticate(String, String) Called method new java.io.InputStreamReader(InputStream) At Auth0JSONAutheticationSource.java:[line 81]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String): new String(byte[], int, int)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.input.AbstractObservationRetriever In method org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String) Called method new String(byte[], int, int) At AbstractObservationRetriever.java:[line 649]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.input.AbstractObservationRetriever In method org.aavso.tools.vstar.input.AbstractObservationRetriever.removeNegativeBytes(String) Called method String.getBytes() At AbstractObservationRetriever.java:[line 643]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getTestRetriever(String[], String): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.plugin.ObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getTestRetriever(String[], String) Called method String.getBytes() At ObservationSourcePluginBase.java:[line 373]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.retrieveAAVSOPhotometryURLObs(InputStream, SeriesType): new java.io.InputStreamReader(InputStream)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLObservationRetriever.retrieveAAVSOPhotometryURLObs(InputStream, SeriesType) Called method new java.io.InputStreamReader(InputStream) At AAVSOPhotometryURLObservationSourceBase.java:[line 268]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever(): new java.io.InputStreamReader(InputStream)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin In method org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever() Called method new java.io.InputStreamReader(InputStream) At TextFormatObservationSourcePlugin.java:[line 91] Another occurrence at TextFormatObservationSourcePlugin.java:[line 114] Another occurrence at TextFormatObservationSourcePlugin.java:[line 119]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever(): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin In method org.aavso.tools.vstar.plugin.ob.src.impl.TextFormatObservationSourcePlugin.getObservationRetriever() Called method String.getBytes() At TextFormatObservationSourcePlugin.java:[line 99]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.scripting.ScriptRunner.runScript(File): new java.io.FileReader(File)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.scripting.ScriptRunner In method org.aavso.tools.vstar.scripting.ScriptRunner.runScript(File) Called method new java.io.FileReader(File) At ScriptRunner.java:[line 100]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.dialog.LogDialog.createLogPanel(): new java.io.FileReader(String)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.dialog.LogDialog In method org.aavso.tools.vstar.ui.dialog.LogDialog.createLogPanel() Called method new java.io.FileReader(String) At LogDialog.java:[line 119]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveRemotePluginInfo(String): new java.io.InputStreamReader(InputStream)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveRemotePluginInfo(String) Called method new java.io.InputStreamReader(InputStream) At PluginManager.java:[line 432]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.task.NewStarFromFileTask.createFileBasedObservationArtefacts(File, ObservationSourceAnalyser): new java.io.FileReader(String)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromFileTask In method org.aavso.tools.vstar.ui.task.NewStarFromFileTask.createFileBasedObservationArtefacts(File, ObservationSourceAnalyser) Called method new java.io.FileReader(String) At NewStarFromFileTask.java:[line 96]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure(): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure() Called method String.getBytes() At NewStarFromObSourcePluginTask.java:[line 155]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.task.ObsListFileSaveTask.doInBackground(): new java.io.PrintWriter(File)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.task.ObsListFileSaveTask In method org.aavso.tools.vstar.ui.task.ObsListFileSaveTask.doInBackground() Called method new java.io.PrintWriter(File) At ObsListFileSaveTask.java:[line 73]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.execute(): java.io.ByteArrayOutputStream.toString()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog In method org.aavso.tools.vstar.ui.vela.VeLaDialog.execute() Called method java.io.ByteArrayOutputStream.toString() At VeLaDialog.java:[line 396]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.execute(): new java.io.PrintStream(OutputStream)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog In method org.aavso.tools.vstar.ui.vela.VeLaDialog.execute() Called method new java.io.PrintStream(OutputStream) At VeLaDialog.java:[line 354] Another occurrence at VeLaDialog.java:[line 357] Another occurrence at VeLaDialog.java:[line 403] Another occurrence at VeLaDialog.java:[line 405]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.ui.vela.VeLaDialog.showOutput(ByteArrayOutputStream): java.io.ByteArrayOutputStream.toString()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog In method org.aavso.tools.vstar.ui.vela.VeLaDialog.showOutput(ByteArrayOutputStream) Called method java.io.ByteArrayOutputStream.toString() At VeLaDialog.java:[line 438]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.util.discrepant.VSXWebServiceZapperLogger.lodge(DiscrepantReport): String.getBytes()
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.util.discrepant.VSXWebServiceZapperLogger In method org.aavso.tools.vstar.util.discrepant.VSXWebServiceZapperLogger.lodge(DiscrepantReport) Called method String.getBytes() At VSXWebServiceZapperLogger.java:[line 75]
Dm	Found reliance on default encoding in org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[]): new java.io.FileReader(String)
	Bug type DM_DEFAULT_ENCODING (click for details) In class org.aavso.tools.vstar.vela.VeLaScriptDriver In method org.aavso.tools.vstar.vela.VeLaScriptDriver.main(String[]) Called method new java.io.FileReader(String) At VeLaScriptDriver.java:[line 71]

Malicious code vulnerability Warnings

Code	Warning
EI	org.aavso.tools.vstar.data.CommentCodes.getCommentcodes() may expose internal representation by returning CommentCodes.commentcodes
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.CommentCodes In method org.aavso.tools.vstar.data.CommentCodes.getCommentcodes() Field org.aavso.tools.vstar.data.CommentCodes.commentcodes At CommentCodes.java:[line 71]
EI	org.aavso.tools.vstar.data.ValidObservation.getDetails() may expose internal representation by returning ValidObservation.details
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.getDetails() Field org.aavso.tools.vstar.data.ValidObservation.details At ValidObservation.java:[line 344]
EI	org.aavso.tools.vstar.data.ValidObservation.getMagnitude() may expose internal representation by returning ValidObservation.magnitude
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.getMagnitude() Field org.aavso.tools.vstar.data.ValidObservation.magnitude At ValidObservation.java:[line 538]
EI	org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getMatcherOps() may expose internal representation by returning AbstractObservationFieldMatcher.ops
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getMatcherOps() Field org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.ops At AbstractObservationFieldMatcher.java:[line 80]
EI	org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getObservationSelectionMessage() may expose internal representation by returning AbstractObservationFieldMatcher.observationSelectionMessage
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getObservationSelectionMessage() Field org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.observationSelectionMessage At AbstractObservationFieldMatcher.java:[line 104]
EI	org.aavso.tools.vstar.data.filter.ObservationFilter.getMatchers() may expose internal representation by returning ObservationFilter.matchers
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.filter.ObservationFilter In method org.aavso.tools.vstar.data.filter.ObservationFilter.getMatchers() Field org.aavso.tools.vstar.data.filter.ObservationFilter.matchers At ObservationFilter.java:[line 87]
EI	org.aavso.tools.vstar.data.validation.AAVSOFormatFieldInfoSource.getFieldIndexMap() may expose internal representation by returning AAVSOFormatFieldInfoSource.fieldIndexMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.validation.AAVSOFormatFieldInfoSource In method org.aavso.tools.vstar.data.validation.AAVSOFormatFieldInfoSource.getFieldIndexMap() Field org.aavso.tools.vstar.data.validation.AAVSOFormatFieldInfoSource.fieldIndexMap At AAVSOFormatFieldInfoSource.java:[line 99]
EI	org.aavso.tools.vstar.data.validation.SimpleFormatFieldInfoSource.getFieldIndexMap() may expose internal representation by returning SimpleFormatFieldInfoSource.fieldIndexMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.validation.SimpleFormatFieldInfoSource In method org.aavso.tools.vstar.data.validation.SimpleFormatFieldInfoSource.getFieldIndexMap() Field org.aavso.tools.vstar.data.validation.SimpleFormatFieldInfoSource.fieldIndexMap At SimpleFormatFieldInfoSource.java:[line 59]
EI	org.aavso.tools.vstar.exception.ObservationValidationWarning.getObservation() may expose internal representation by returning ObservationValidationWarning.ob
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.exception.ObservationValidationWarning In method org.aavso.tools.vstar.exception.ObservationValidationWarning.getObservation() Field org.aavso.tools.vstar.exception.ObservationValidationWarning.ob At ObservationValidationWarning.java:[line 44]
EI	org.aavso.tools.vstar.input.AbstractObservationRetriever.getInvalidObservations() may expose internal representation by returning AbstractObservationRetriever.invalidObservations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.input.AbstractObservationRetriever In method org.aavso.tools.vstar.input.AbstractObservationRetriever.getInvalidObservations() Field org.aavso.tools.vstar.input.AbstractObservationRetriever.invalidObservations At AbstractObservationRetriever.java:[line 237]
EI	org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservationCategoryMap() may expose internal representation by returning AbstractObservationRetriever.validObservationCategoryMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.input.AbstractObservationRetriever In method org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservationCategoryMap() Field org.aavso.tools.vstar.input.AbstractObservationRetriever.validObservationCategoryMap At AbstractObservationRetriever.java:[line 349]
EI	org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservations() may expose internal representation by returning AbstractObservationRetriever.validObservations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.input.AbstractObservationRetriever In method org.aavso.tools.vstar.input.AbstractObservationRetriever.getValidObservations() Field org.aavso.tools.vstar.input.AbstractObservationRetriever.validObservations At AbstractObservationRetriever.java:[line 230]
EI	org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getInputStreams() may expose internal representation by returning ObservationSourcePluginBase.inputStreams
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.plugin.ObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.getInputStreams() Field org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.inputStreams At ObservationSourcePluginBase.java:[line 194]
EI	org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterNameValuePairs() may expose internal representation by returning CommonTextFormatSinkPluginBase.DELIMS
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase In method org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterNameValuePairs() Field org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.DELIMS At CommonTextFormatSinkPluginBase.java:[line 48]
EI	org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterSuffixValuePairs() may expose internal representation by returning CommonTextFormatSinkPluginBase.SUFFIXES
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase In method org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.getDelimiterSuffixValuePairs() Field org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.SUFFIXES At CommonTextFormatSinkPluginBase.java:[line 53]
EI	org.aavso.tools.vstar.ui.MainFrame.getStatusPane() may expose internal representation by returning MainFrame.statusPane
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.MainFrame In method org.aavso.tools.vstar.ui.MainFrame.getStatusPane() Field org.aavso.tools.vstar.ui.MainFrame.statusPane At MainFrame.java:[line 113]
EI	org.aavso.tools.vstar.ui.NamedComponent.getComponent() may expose internal representation by returning NamedComponent.component
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.NamedComponent In method org.aavso.tools.vstar.ui.NamedComponent.getComponent() Field org.aavso.tools.vstar.ui.NamedComponent.component At NamedComponent.java:[line 54]
EI	org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.getDefaultFileExtensions() may expose internal representation by returning AdditiveLoadFileOrUrlChooser.extensions
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser In method org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.getDefaultFileExtensions() Field org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.extensions At AdditiveLoadFileOrUrlChooser.java:[line 111]
EI	org.aavso.tools.vstar.ui.dialog.Checkbox.getUIComponent() may expose internal representation by returning Checkbox.checkbox
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.Checkbox In method org.aavso.tools.vstar.ui.dialog.Checkbox.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.Checkbox.checkbox At Checkbox.java:[line 63]
EI	org.aavso.tools.vstar.ui.dialog.NumberFieldBase.getUIComponent() may expose internal representation by returning NumberFieldBase.textField
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.NumberFieldBase In method org.aavso.tools.vstar.ui.dialog.NumberFieldBase.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.NumberFieldBase.textField At NumberFieldBase.java:[line 103]
EI	org.aavso.tools.vstar.ui.dialog.SelectableTextField.getUIComponent() may expose internal representation by returning SelectableTextField.textChooser
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.SelectableTextField In method org.aavso.tools.vstar.ui.dialog.SelectableTextField.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.SelectableTextField.textChooser At SelectableTextField.java:[line 124]
EI	org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane.getStarGroups() may expose internal representation by returning StarGroupSelectionPane.starGroups
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane In method org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane.getStarGroups() Field org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane.starGroups At StarGroupSelectionPane.java:[line 440]
EI	org.aavso.tools.vstar.ui.dialog.TextArea.getUIComponent() may expose internal representation by returning TextArea.textArea
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.TextArea In method org.aavso.tools.vstar.ui.dialog.TextArea.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.TextArea.textArea At TextArea.java:[line 154]
EI	org.aavso.tools.vstar.ui.dialog.TextAreaTabs.getUIComponent() may expose internal representation by returning TextAreaTabs.tabs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.TextAreaTabs In method org.aavso.tools.vstar.ui.dialog.TextAreaTabs.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.TextAreaTabs.tabs At TextAreaTabs.java:[line 155]
EI	org.aavso.tools.vstar.ui.dialog.TextDialog.getTextFields() may expose internal representation by returning TextDialog.textFields
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.TextDialog In method org.aavso.tools.vstar.ui.dialog.TextDialog.getTextFields() Field org.aavso.tools.vstar.ui.dialog.TextDialog.textFields At TextDialog.java:[line 143]
EI	org.aavso.tools.vstar.ui.dialog.TextField.getUIComponent() may expose internal representation by returning TextField.textField
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.TextField In method org.aavso.tools.vstar.ui.dialog.TextField.getUIComponent() Field org.aavso.tools.vstar.ui.dialog.TextField.textField At TextField.java:[line 115]
EI	org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog.getHarmonics() may expose internal representation by returning HarmonicInputDialog.harmonicsPerSelectedPeriod
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog In method org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog.getHarmonics() Field org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog.harmonicsPerSelectedPeriod At HarmonicInputDialog.java:[line 175]
EI	org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getChart() may expose internal representation by returning PeriodAnalysis2DChartPane.chart
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane In method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getChart() Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.chart At PeriodAnalysis2DChartPane.java:[line 130]
EI	org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getModel() may expose internal representation by returning PeriodAnalysis2DChartPane.model
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane In method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.getModel() Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.model At PeriodAnalysis2DChartPane.java:[line 137]
EI	org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane.getTable() may expose internal representation by returning PeriodAnalysisDataTablePane.table
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane In method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane.getTable() Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane.table At PeriodAnalysisDataTablePane.java:[line 353]
EI	org.aavso.tools.vstar.ui.dialog.period.refinement.PeriodGatheringPane.getPeriods() may expose internal representation by returning PeriodGatheringPane.periods
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.refinement.PeriodGatheringPane In method org.aavso.tools.vstar.ui.dialog.period.refinement.PeriodGatheringPane.getPeriods() Field org.aavso.tools.vstar.ui.dialog.period.refinement.PeriodGatheringPane.periods At PeriodGatheringPane.java:[line 80]
EI	org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getChart() may expose internal representation by returning WWZPlotPane.chart
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane In method org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getChart() Field org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.chart At WWZPlotPane.java:[line 98]
EI	org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getModel() may expose internal representation by returning WWZPlotPane.model
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane In method org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.getModel() Field org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.model At WWZPlotPane.java:[line 105]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation.getManager() may expose internal representation by returning PluginManagementOperation.manager
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation.getManager() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation.manager At PluginManagementOperation.java:[line 41]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLibs() may expose internal representation by returning PluginManager.libs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLibs() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.libs At PluginManager.java:[line 299]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalDescriptionsToJarName() may expose internal representation by returning PluginManager.localDescriptions
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalDescriptionsToJarName() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.localDescriptions At PluginManager.java:[line 285]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalPluginsByJarName() may expose internal representation by returning PluginManager.localPlugins
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getLocalPluginsByJarName() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.localPlugins At PluginManager.java:[line 278]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemoteDescriptionsToJarName() may expose internal representation by returning PluginManager.remoteDescriptions
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemoteDescriptionsToJarName() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.remoteDescriptions At PluginManager.java:[line 264]
EI	org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemotePluginsByJarName() may expose internal representation by returning PluginManager.remotePlugins
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.getRemotePluginsByJarName() Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.remotePlugins At PluginManager.java:[line 155]
EI	org.aavso.tools.vstar.ui.dialog.prefs.NewGroupWithStarsDialog.getStarList() may expose internal representation by returning NewGroupWithStarsDialog.starList
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.NewGroupWithStarsDialog In method org.aavso.tools.vstar.ui.dialog.prefs.NewGroupWithStarsDialog.getStarList() Field org.aavso.tools.vstar.ui.dialog.prefs.NewGroupWithStarsDialog.starList At NewGroupWithStarsDialog.java:[line 95]
EI	org.aavso.tools.vstar.ui.dialog.prefs.SeriesColorSelectionPane.getChangedSeriesColorMap() may expose internal representation by returning SeriesColorSelectionPane.changedSeriesColorMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.SeriesColorSelectionPane In method org.aavso.tools.vstar.ui.dialog.prefs.SeriesColorSelectionPane.getChangedSeriesColorMap() Field org.aavso.tools.vstar.ui.dialog.prefs.SeriesColorSelectionPane.changedSeriesColorMap At SeriesColorSelectionPane.java:[line 216]
EI	org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane.getChangedSeriesSizeMap() may expose internal representation by returning SeriesSizeSelectionPane.changedSeriesSizeMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane In method org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane.getChangedSeriesSizeMap() Field org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane.changedSeriesSizeMap At SeriesSizeSelectionPane.java:[line 285]
EI	org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.getNextPane() may expose internal representation by returning AbstractSeriesVisibilityDialog.nextPane
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog In method org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.getNextPane() Field org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.nextPane At AbstractSeriesVisibilityDialog.java:[line 130]
EI	org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.getVisibilityDeltaMap() may expose internal representation by returning SeriesVisibilityPane.visibilityDeltaMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane In method org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.getVisibilityDeltaMap() Field org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.visibilityDeltaMap At SeriesVisibilityPane.java:[line 481]
EI	org.aavso.tools.vstar.ui.mediator.DocumentManager.getStatsInfo() may expose internal representation by returning DocumentManager.statsInfo
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.DocumentManager In method org.aavso.tools.vstar.ui.mediator.DocumentManager.getStatsInfo() Field org.aavso.tools.vstar.ui.mediator.DocumentManager.statsInfo At DocumentManager.java:[line 281]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getAnalysisTypeChangeNotifier() may expose internal representation by returning Mediator.analysisTypeChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getAnalysisTypeChangeNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.analysisTypeChangeNotifier At Mediator.java:[line 451]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getDiscrepantObservationNotifier() may expose internal representation by returning Mediator.discrepantObservationNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getDiscrepantObservationNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.discrepantObservationNotifier At Mediator.java:[line 479]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getDocumentManager() may expose internal representation by returning Mediator.documentManager
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getDocumentManager() Field org.aavso.tools.vstar.ui.mediator.Mediator.documentManager At Mediator.java:[line 965]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getExcludedObservationNotifier() may expose internal representation by returning Mediator.excludedObservationNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getExcludedObservationNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.excludedObservationNotifier At Mediator.java:[line 486]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getFilteredObservationNotifier() may expose internal representation by returning Mediator.filteredObservationNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getFilteredObservationNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.filteredObservationNotifier At Mediator.java:[line 556]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getHarmonicSearchNotifier() may expose internal representation by returning Mediator.harmonicSearchNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getHarmonicSearchNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.harmonicSearchNotifier At Mediator.java:[line 605]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getMeanSourceSeriesChangeNotifier() may expose internal representation by returning Mediator.meanSourceSeriesChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getMeanSourceSeriesChangeNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.meanSourceSeriesChangeNotifier At Mediator.java:[line 542]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getModelCreationNotifier() may expose internal representation by returning Mediator.modelCreationNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getModelCreationNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.modelCreationNotifier At Mediator.java:[line 570]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getModelDialog() may expose internal representation by returning Mediator.modelDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getModelDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.modelDialog At Mediator.java:[line 936]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionMessage() may expose internal representation by returning Mediator.modelSelectionMessage
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionMessage() Field org.aavso.tools.vstar.ui.mediator.Mediator.modelSelectionMessage At Mediator.java:[line 444]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionNofitier() may expose internal representation by returning Mediator.modelSelectionNofitier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getModelSelectionNofitier() Field org.aavso.tools.vstar.ui.mediator.Mediator.modelSelectionNofitier At Mediator.java:[line 563]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getMultipleObservationSelectionNotifier() may expose internal representation by returning Mediator.multipleObservationSelectionNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getMultipleObservationSelectionNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.multipleObservationSelectionNotifier At Mediator.java:[line 500]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarMessageList() may expose internal representation by returning Mediator.newStarMessageList
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarMessageList() Field org.aavso.tools.vstar.ui.mediator.Mediator.newStarMessageList At Mediator.java:[line 407]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarNotifier() may expose internal representation by returning Mediator.newStarNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getNewStarNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.newStarNotifier At Mediator.java:[line 465]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getObsFilterDialog() may expose internal representation by returning Mediator.obsFilterDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getObsFilterDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.obsFilterDialog At Mediator.java:[line 926]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getObservationFiltersDialog() may expose internal representation by returning Mediator.observationFiltersDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getObservationFiltersDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.observationFiltersDialog At Mediator.java:[line 956]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getObservationSelectionNotifier() may expose internal representation by returning Mediator.observationSelectionNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getObservationSelectionNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.observationSelectionNotifier At Mediator.java:[line 493]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPanRequestNotifier() may expose internal representation by returning Mediator.panRequestNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPanRequestNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.panRequestNotifier At Mediator.java:[line 577]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisRefinementNotifier() may expose internal representation by returning Mediator.periodAnalysisRefinementNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisRefinementNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.periodAnalysisRefinementNotifier At Mediator.java:[line 535]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisSelectionNotifier() may expose internal representation by returning Mediator.periodAnalysisSelectionNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodAnalysisSelectionNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.periodAnalysisSelectionNotifier At Mediator.java:[line 507]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodChangeNotifier() may expose internal representation by returning Mediator.periodChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPeriodChangeNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.periodChangeNotifier At Mediator.java:[line 514]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseChangeNotifier() may expose internal representation by returning Mediator.phaseChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseChangeNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.phaseChangeNotifier At Mediator.java:[line 521]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseDialog() may expose internal representation by returning Mediator.phaseDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.phaseDialog At Mediator.java:[line 946]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseParameterDialog() may expose internal representation by returning Mediator.phaseParameterDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseParameterDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.phaseParameterDialog At Mediator.java:[line 916]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseSelectionNotifier() may expose internal representation by returning Mediator.phaseSelectionNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getPhaseSelectionNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.phaseSelectionNotifier At Mediator.java:[line 528]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getProgressNotifier() may expose internal representation by returning Mediator.progressNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getProgressNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.progressNotifier At Mediator.java:[line 472]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesCreationNotifier() may expose internal representation by returning Mediator.seriesCreationNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesCreationNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.seriesCreationNotifier At Mediator.java:[line 612]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesVisibilityChangeNotifier() may expose internal representation by returning Mediator.seriesVisibilityChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getSeriesVisibilityChangeNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.seriesVisibilityChangeNotifier At Mediator.java:[line 598]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getStopRequestNotifier() may expose internal representation by returning Mediator.stopRequestNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getStopRequestNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.stopRequestNotifier At Mediator.java:[line 591]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getUndoActionNotifier() may expose internal representation by returning Mediator.undoActionNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getUndoActionNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.undoActionNotifier At Mediator.java:[line 584]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getUndoableActionManager() may expose internal representation by returning Mediator.undoableActionManager
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getUndoableActionManager() Field org.aavso.tools.vstar.ui.mediator.Mediator.undoableActionManager At Mediator.java:[line 977]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getValidObsList() may expose internal representation by returning Mediator.validObsList
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getValidObsList() Field org.aavso.tools.vstar.ui.mediator.Mediator.validObsList At Mediator.java:[line 387]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getValidObservationCategoryMap() may expose internal representation by returning Mediator.validObservationCategoryMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getValidObservationCategoryMap() Field org.aavso.tools.vstar.ui.mediator.Mediator.validObservationCategoryMap At Mediator.java:[line 414]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getVelaFileSaveDialog() may expose internal representation by returning Mediator.velaFileSaveDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getVelaFileSaveDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.velaFileSaveDialog At Mediator.java:[line 626]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getVelaXMLsaveDialog() may expose internal representation by returning Mediator.velaXMLsaveDialog
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getVelaXMLsaveDialog() Field org.aavso.tools.vstar.ui.mediator.Mediator.velaXMLsaveDialog At Mediator.java:[line 640]
EI	org.aavso.tools.vstar.ui.mediator.Mediator.getZoomRequestNotifier() may expose internal representation by returning Mediator.zoomRequestNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getZoomRequestNotifier() Field org.aavso.tools.vstar.ui.mediator.Mediator.zoomRequestNotifier At Mediator.java:[line 549]
EI	org.aavso.tools.vstar.ui.mediator.StarInfo.getRetriever() may expose internal representation by returning StarInfo.retriever
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.StarInfo In method org.aavso.tools.vstar.ui.mediator.StarInfo.getRetriever() Field org.aavso.tools.vstar.ui.mediator.StarInfo.retriever At StarInfo.java:[line 185]
EI	org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getMeansListPane() may expose internal representation by returning AnalysisTypeChangeMessage.meansListPane
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getMeansListPane() Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.meansListPane At AnalysisTypeChangeMessage.java:[line 98]
EI	org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsAndMeanChartPane() may expose internal representation by returning AnalysisTypeChangeMessage.obsAndMeanChartPane
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsAndMeanChartPane() Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.obsAndMeanChartPane At AnalysisTypeChangeMessage.java:[line 84]
EI	org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsListPane() may expose internal representation by returning AnalysisTypeChangeMessage.obsListPane
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.getObsListPane() Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.obsListPane At AnalysisTypeChangeMessage.java:[line 91]
EI	org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage.getObservation() may expose internal representation by returning DiscrepantObservationMessage.observation
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage In method org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage.getObservation() Field org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage.observation At DiscrepantObservationMessage.java:[line 48]
EI	org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage.getObservations() may expose internal representation by returning ExcludedObservationMessage.observations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage In method org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage.getObservations() Field org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage.observations At ExcludedObservationMessage.java:[line 51]
EI	org.aavso.tools.vstar.ui.mediator.message.FilteredObservationMessage.getFilteredObs() may expose internal representation by returning FilteredObservationMessage.filteredObs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.FilteredObservationMessage In method org.aavso.tools.vstar.ui.mediator.message.FilteredObservationMessage.getFilteredObs() Field org.aavso.tools.vstar.ui.mediator.message.FilteredObservationMessage.filteredObs At FilteredObservationMessage.java:[line 71]
EI	org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage.getHarmonics() may expose internal representation by returning HarmonicSearchResultMessage.harmonics
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage In method org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage.getHarmonics() Field org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage.harmonics At HarmonicSearchResultMessage.java:[line 57]
EI	org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage.getObservations() may expose internal representation by returning MultipleObservationSelectionMessage.observations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage In method org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage.getObservations() Field org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage.observations At MultipleObservationSelectionMessage.java:[line 50]
EI	org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getLoadDate() may expose internal representation by returning NewStarMessage.loadDate
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getLoadDate() Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.loadDate At NewStarMessage.java:[line 87]
EI	org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObsCategoryMap() may expose internal representation by returning NewStarMessage.obsCategoryMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObsCategoryMap() Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.obsCategoryMap At NewStarMessage.java:[line 108]
EI	org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObservations() may expose internal representation by returning NewStarMessage.obs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getObservations() Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.obs At NewStarMessage.java:[line 101]
EI	org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getStarInfo() may expose internal representation by returning NewStarMessage.starInfo
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.getStarInfo() Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.starInfo At NewStarMessage.java:[line 94]
EI	org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage.getObservation() may expose internal representation by returning ObservationSelectionMessage.observation
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage In method org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage.getObservation() Field org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage.observation At ObservationSelectionMessage.java:[line 48]
EI	org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getNewTopHits() may expose internal representation by returning PeriodAnalysisRefinementMessage.newTopHits
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getNewTopHits() Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.newTopHits At PeriodAnalysisRefinementMessage.java:[line 65]
EI	org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedData() may expose internal representation by returning PeriodAnalysisRefinementMessage.refinedData
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedData() Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.refinedData At PeriodAnalysisRefinementMessage.java:[line 51]
EI	org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedTopHits() may expose internal representation by returning PeriodAnalysisRefinementMessage.refinedTopHits
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.getRefinedTopHits() Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.refinedTopHits At PeriodAnalysisRefinementMessage.java:[line 58]
EI	org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.getSeriesVisibilityMap() may expose internal representation by returning PhaseChangeMessage.seriesVisibilityMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.getSeriesVisibilityMap() Field org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.seriesVisibilityMap At PhaseChangeMessage.java:[line 73]
EI	org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage.getSeriesVisibilityMap() may expose internal representation by returning PhaseSelectionMessage.seriesVisibilityMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage In method org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage.getSeriesVisibilityMap() Field org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage.seriesVisibilityMap At PhaseSelectionMessage.java:[line 75]
EI	org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage.getObs() may expose internal representation by returning SeriesCreationMessage.obs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage In method org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage.getObs() Field org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage.obs At SeriesCreationMessage.java:[line 51]
EI	org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage.getVisibleSeries() may expose internal representation by returning SeriesVisibilityChangeMessage.visibleSeries
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage.getVisibleSeries() Field org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage.visibleSeries At SeriesVisibilityChangeMessage.java:[line 48]
EI	org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel.getObs() may expose internal representation by returning AbstractSyntheticObservationTableModel.obs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel In method org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel.getObs() Field org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel.obs At AbstractSyntheticObservationTableModel.java:[line 58]
EI	org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.getData() may expose internal representation by returning PeriodAnalysisDataTableModel.data
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel In method org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.getData() Field org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.data At PeriodAnalysisDataTableModel.java:[line 59]
EI	org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsInserter() may expose internal representation by returning ValidObservationTableModel.obsInserter
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsInserter() Field org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.obsInserter At ValidObservationTableModel.java:[line 120]
EI	org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsSourceListMap() may expose internal representation by returning ValidObservationTableModel.obsSourceListMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObsSourceListMap() Field org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.obsSourceListMap At ValidObservationTableModel.java:[line 99]
EI	org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObservations() may expose internal representation by returning ValidObservationTableModel.validObservations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.getObservations() Field org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.validObservations At ValidObservationTableModel.java:[line 113]
EI	org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getStats() may expose internal representation by returning WWZDataTableModel.stats
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.WWZDataTableModel In method org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getStats() Field org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.stats At WWZDataTableModel.java:[line 59]
EI	org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getWwt() may expose internal representation by returning WWZDataTableModel.wwt
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.list.WWZDataTableModel In method org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.getWwt() Field org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.wwt At WWZDataTableModel.java:[line 66]
EI	org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getFit() may expose internal representation by returning ContinuousModelFunction.fit
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction In method org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getFit() Field org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.fit At ContinuousModelFunction.java:[line 123]
EI	org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getPpModel() may expose internal representation by returning ContinuousModelFunction.ppModel
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction In method org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.getPpModel() Field org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.ppModel At ContinuousModelFunction.java:[line 102]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeanObsList() may expose internal representation by returning ObservationAndMeanPlotModel.meanObsList
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeanObsList() Field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.meanObsList At ObservationAndMeanPlotModel.java:[line 350]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeansChangeNotifier() may expose internal representation by returning ObservationAndMeanPlotModel.meansChangeNotifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getMeansChangeNotifier() Field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.meansChangeNotifier At ObservationAndMeanPlotModel.java:[line 364]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getTimeElementEntity() may expose internal representation by returning ObservationAndMeanPlotModel.timeElementEntity
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.getTimeElementEntity() Field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.timeElementEntity At ObservationAndMeanPlotModel.java:[line 138]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToObSrcListMap() may expose internal representation by returning ObservationPlotModel.seriesNumToObSrcListMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToObSrcListMap() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.seriesNumToObSrcListMap At ObservationPlotModel.java:[line 657]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToSrcTypeMap() may expose internal representation by returning ObservationPlotModel.seriesNumToSrcTypeMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesNumToSrcTypeMap() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.seriesNumToSrcTypeMap At ObservationPlotModel.java:[line 671]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesVisibilityMap() may expose internal representation by returning ObservationPlotModel.seriesVisibilityMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesVisibilityMap() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.seriesVisibilityMap At ObservationPlotModel.java:[line 678]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesWhoseElementsShouldBeJoinedVisually() may expose internal representation by returning ObservationPlotModel.seriesToBeJoinedVisually
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSeriesWhoseElementsShouldBeJoinedVisually() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.seriesToBeJoinedVisually At ObservationPlotModel.java:[line 557]
EI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSrcTypeToSeriesNumMap() may expose internal representation by returning ObservationPlotModel.srcTypeToSeriesNumMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getSrcTypeToSeriesNumMap() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.srcTypeToSeriesNumMap At ObservationPlotModel.java:[line 664]
EI	org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getAnalysisValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.analysisValues
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel In method org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getAnalysisValues() Field org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.analysisValues At PeriodAnalysis2DPlotModel.java:[line 75]
EI	org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getDomainValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.domainValues
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel In method org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getDomainValues() Field org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.domainValues At PeriodAnalysis2DPlotModel.java:[line 82]
EI	org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getRangeValues() may expose internal representation by returning PeriodAnalysis2DPlotModel.rangeValues
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel In method org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.getRangeValues() Field org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.rangeValues At PeriodAnalysis2DPlotModel.java:[line 89]
EI	org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel.getStats() may expose internal representation by returning WWZ2DPlotModel.stats
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel In method org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel.getStats() Field org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel.stats At WWZ2DPlotModel.java:[line 58]
EI	org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getInvalidDataTable() may expose internal representation by returning ObservationListPane.invalidDataTable
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.ObservationListPane In method org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getInvalidDataTable() Field org.aavso.tools.vstar.ui.pane.list.ObservationListPane.invalidDataTable At ObservationListPane.java:[line 401]
EI	org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getLastObSelected() may expose internal representation by returning ObservationListPane.lastObSelected
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.ObservationListPane In method org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getLastObSelected() Field org.aavso.tools.vstar.ui.pane.list.ObservationListPane.lastObSelected At ObservationListPane.java:[line 408]
EI	org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getValidDataTable() may expose internal representation by returning ObservationListPane.validDataTable
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.ObservationListPane In method org.aavso.tools.vstar.ui.pane.list.ObservationListPane.getValidDataTable() Field org.aavso.tools.vstar.ui.pane.list.ObservationListPane.validDataTable At ObservationListPane.java:[line 394]
EI	org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getLastObSelected() may expose internal representation by returning SyntheticObservationListPane.lastObSelected
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane In method org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getLastObSelected() Field org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.lastObSelected At SyntheticObservationListPane.java:[line 98]
EI	org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTable() may expose internal representation by returning SyntheticObservationListPane.obsTable
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane In method org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTable() Field org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.obsTable At SyntheticObservationListPane.java:[line 91]
EI	org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTableModel() may expose internal representation by returning SyntheticObservationListPane.obsTableModel
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane In method org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.getObsTableModel() Field org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.obsTableModel At SyntheticObservationListPane.java:[line 84]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartControlPanel() may expose internal representation by returning AbstractObservationPlotPane.chartControlPanel
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartControlPanel() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.chartControlPanel At AbstractObservationPlotPane.java:[line 239]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartPanel() may expose internal representation by returning AbstractObservationPlotPane.chartPanel
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getChartPanel() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.chartPanel At AbstractObservationPlotPane.java:[line 232]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastObSelected() may expose internal representation by returning AbstractObservationPlotPane.lastObSelected
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastObSelected() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.lastObSelected At AbstractObservationPlotPane.java:[line 267]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastPointClicked() may expose internal representation by returning AbstractObservationPlotPane.lastPointClicked
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getLastPointClicked() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.lastPointClicked At AbstractObservationPlotPane.java:[line 260]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getObsInfo() may expose internal representation by returning AbstractObservationPlotPane.obsInfo
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getObsInfo() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsInfo At AbstractObservationPlotPane.java:[line 246]
EI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getRenderer() may expose internal representation by returning AbstractObservationPlotPane.renderer
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.getRenderer() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.renderer At AbstractObservationPlotPane.java:[line 253]
EI	org.aavso.tools.vstar.ui.pane.plot.ObservationAndMeanPlotPane.getObsModel() may expose internal representation by returning AbstractObservationPlotPane.obsModel
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.ObservationAndMeanPlotPane In method org.aavso.tools.vstar.ui.pane.plot.ObservationAndMeanPlotPane.getObsModel() Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsModel At ObservationAndMeanPlotPane.java:[line 141]
EI	org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.getObsModels() may expose internal representation by returning PhaseAndMeanPlotPane.obsAndMeanModels
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane In method org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.getObsModels() Field org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.obsAndMeanModels At PhaseAndMeanPlotPane.java:[line 123]
EI	org.aavso.tools.vstar.ui.resources.StarGroups.getNotifier() may expose internal representation by returning StarGroups.notifier
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method org.aavso.tools.vstar.ui.resources.StarGroups.getNotifier() Field org.aavso.tools.vstar.ui.resources.StarGroups.notifier At StarGroups.java:[line 81]
EI	org.aavso.tools.vstar.util.TSBase.getObservations() may expose internal representation by returning TSBase.observations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.TSBase In method org.aavso.tools.vstar.util.TSBase.getObservations() Field org.aavso.tools.vstar.util.TSBase.observations At TSBase.java:[line 125]
EI	org.aavso.tools.vstar.util.model.AbstractModel.getFit() may expose internal representation by returning AbstractModel.fit
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.AbstractModel In method org.aavso.tools.vstar.util.model.AbstractModel.getFit() Field org.aavso.tools.vstar.util.model.AbstractModel.fit At AbstractModel.java:[line 145]
EI	org.aavso.tools.vstar.util.model.AbstractModel.getFunctionStrings() may expose internal representation by returning AbstractModel.functionStrMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.AbstractModel In method org.aavso.tools.vstar.util.model.AbstractModel.getFunctionStrings() Field org.aavso.tools.vstar.util.model.AbstractModel.functionStrMap At AbstractModel.java:[line 182]
EI	org.aavso.tools.vstar.util.model.AbstractModel.getResiduals() may expose internal representation by returning AbstractModel.residuals
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.AbstractModel In method org.aavso.tools.vstar.util.model.AbstractModel.getResiduals() Field org.aavso.tools.vstar.util.model.AbstractModel.residuals At AbstractModel.java:[line 154]
EI	org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFit() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.fit
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFit() Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.fit At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 140]
EI	org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFunctionStrings() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.functionStrMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getFunctionStrings() Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.functionStrMap At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 360]
EI	org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getHarmonics() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.harmonics
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getHarmonics() Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.harmonics At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 132]
EI	org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getParameters() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.parameters
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getParameters() Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.parameters At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 156]
EI	org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getResiduals() may expose internal representation by returning PeriodAnalysisDerivedMultiPeriodicModel.residuals
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.getResiduals() Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.residuals At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 148]
EI	org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getHarmonicMap() may expose internal representation by returning RelativeAmplitudeAndPhaseCreator.harmonicMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator In method org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getHarmonicMap() Field org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.harmonicMap At RelativeAmplitudeAndPhaseCreator.java:[line 61]
EI	org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFit() may expose internal representation by returning TSPolynomialFitter.fit
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.TSPolynomialFitter In method org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFit() Field org.aavso.tools.vstar.util.model.TSPolynomialFitter.fit At TSPolynomialFitter.java:[line 141]
EI	org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFunctionStrings() may expose internal representation by returning TSPolynomialFitter.functionStrMap
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.TSPolynomialFitter In method org.aavso.tools.vstar.util.model.TSPolynomialFitter.getFunctionStrings() Field org.aavso.tools.vstar.util.model.TSPolynomialFitter.functionStrMap At TSPolynomialFitter.java:[line 384]
EI	org.aavso.tools.vstar.util.model.TSPolynomialFitter.getResiduals() may expose internal representation by returning TSPolynomialFitter.residuals
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.TSPolynomialFitter In method org.aavso.tools.vstar.util.model.TSPolynomialFitter.getResiduals() Field org.aavso.tools.vstar.util.model.TSPolynomialFitter.residuals At TSPolynomialFitter.java:[line 149]
EI	org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getFit() may expose internal representation by returning WWZMultiperiodicModel.fit
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.WWZMultiperiodicModel In method org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getFit() Field org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.fit At WWZMultiperiodicModel.java:[line 171]
EI	org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getResiduals() may expose internal representation by returning WWZMultiperiodicModel.residuals
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.model.WWZMultiperiodicModel In method org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.getResiduals() Field org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.residuals At WWZMultiperiodicModel.java:[line 179]
EI	org.aavso.tools.vstar.util.notification.ListChangeMessage.getSource() may expose internal representation by returning ListChangeMessage.source
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.notification.ListChangeMessage In method org.aavso.tools.vstar.util.notification.ListChangeMessage.getSource() Field org.aavso.tools.vstar.util.notification.ListChangeMessage.source At ListChangeMessage.java:[line 91]
EI	org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoordTypes() may expose internal representation by returning PeriodAnalysisDataPoint.coordTypes
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoordTypes() Field org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.coordTypes At PeriodAnalysisDataPoint.java:[line 64]
EI	org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoords() may expose internal representation by returning PeriodAnalysisDataPoint.coords
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.getCoords() Field org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.coords At PeriodAnalysisDataPoint.java:[line 68]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getAdjustedJDs() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.tvec
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getAdjustedJDs() Field org.aavso.tools.vstar.util.TSBase.tvec At TSDcDft.java:[line 251]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getMags() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.xvec
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getMags() Field org.aavso.tools.vstar.util.TSBase.xvec At TSDcDft.java:[line 258]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getResultSeries() may expose internal representation by returning TSDcDft.resultSeries
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getResultSeries() Field org.aavso.tools.vstar.util.period.dcdft.TSDcDft.resultSeries At TSDcDft.java:[line 272]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getTopHits() may expose internal representation by returning TSDcDft.topHits
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getTopHits() Field org.aavso.tools.vstar.util.period.dcdft.TSDcDft.topHits At TSDcDft.java:[line 307]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getWeights() may expose internal representation by returning org.aavso.tools.vstar.util.TSBase.wvec
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.getWeights() Field org.aavso.tools.vstar.util.TSBase.wvec At TSDcDft.java:[line 265]
EI	org.aavso.tools.vstar.util.period.dcdft.TSDcDft.refineByFrequency(List, List, List) may expose internal representation by returning TSDcDft.deltaTopHits
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.refineByFrequency(List, List, List) Field org.aavso.tools.vstar.util.period.dcdft.TSDcDft.deltaTopHits At TSDcDft.java:[line 339]
EI	org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getMaximalStats() may expose internal representation by returning WeightedWaveletZTransform.maximalStats
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getMaximalStats() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maximalStats At WeightedWaveletZTransform.java:[line 245]
EI	org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getObs() may expose internal representation by returning WeightedWaveletZTransform.obs
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getObs() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.obs At WeightedWaveletZTransform.java:[line 156]
EI	org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getStats() may expose internal representation by returning WeightedWaveletZTransform.stats
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.getStats() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.stats At WeightedWaveletZTransform.java:[line 238]
EI	org.aavso.tools.vstar.util.stats.Bin.getMagnitudes() may expose internal representation by returning Bin.magnitudes
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.stats.Bin In method org.aavso.tools.vstar.util.stats.Bin.getMagnitudes() Field org.aavso.tools.vstar.util.stats.Bin.magnitudes At Bin.java:[line 54]
EI	org.aavso.tools.vstar.util.stats.Bin.getMeanObservation() may expose internal representation by returning Bin.meanObservation
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.stats.Bin In method org.aavso.tools.vstar.util.stats.Bin.getMeanObservation() Field org.aavso.tools.vstar.util.stats.Bin.meanObservation At Bin.java:[line 47]
EI	org.aavso.tools.vstar.util.stats.BinningResult.getMagnitudeBins() may expose internal representation by returning BinningResult.magnitudeBins
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.stats.BinningResult In method org.aavso.tools.vstar.util.stats.BinningResult.getMagnitudeBins() Field org.aavso.tools.vstar.util.stats.BinningResult.magnitudeBins At BinningResult.java:[line 94]
EI	org.aavso.tools.vstar.util.stats.BinningResult.getMeanObservations() may expose internal representation by returning BinningResult.meanObservations
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.util.stats.BinningResult In method org.aavso.tools.vstar.util.stats.BinningResult.getMeanObservations() Field org.aavso.tools.vstar.util.stats.BinningResult.meanObservations At BinningResult.java:[line 87]
EI	org.aavso.tools.vstar.vela.AST.getChildren() may expose internal representation by returning AST.children
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.AST In method org.aavso.tools.vstar.vela.AST.getChildren() Field org.aavso.tools.vstar.vela.AST.children At AST.java:[line 123]
EI	org.aavso.tools.vstar.vela.AST.getOperand() may expose internal representation by returning AST.literal
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.AST In method org.aavso.tools.vstar.vela.AST.getOperand() Field org.aavso.tools.vstar.vela.AST.literal At AST.java:[line 95]
EI	org.aavso.tools.vstar.vela.FunctionExecutor.getParameterTypes() may expose internal representation by returning FunctionExecutor.parameterTypes
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor In method org.aavso.tools.vstar.vela.FunctionExecutor.getParameterTypes() Field org.aavso.tools.vstar.vela.FunctionExecutor.parameterTypes At FunctionExecutor.java:[line 132]
EI	org.aavso.tools.vstar.vela.Operand.functionVal() may expose internal representation by returning Operand.functionVal
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.Operand In method org.aavso.tools.vstar.vela.Operand.functionVal() Field org.aavso.tools.vstar.vela.Operand.functionVal At Operand.java:[line 170]
EI	org.aavso.tools.vstar.vela.Operand.listVal() may expose internal representation by returning Operand.listVal
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.Operand In method org.aavso.tools.vstar.vela.Operand.listVal() Field org.aavso.tools.vstar.vela.Operand.listVal At Operand.java:[line 156]
EI	org.aavso.tools.vstar.vela.VeLaInterpreter.getEnvironments() may expose internal representation by returning VeLaInterpreter.environments
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method org.aavso.tools.vstar.vela.VeLaInterpreter.getEnvironments() Field org.aavso.tools.vstar.vela.VeLaInterpreter.environments At VeLaInterpreter.java:[line 191]
EI	org.aavso.tools.vstar.vela.VeLaInterpreter.getStack() may expose internal representation by returning VeLaInterpreter.stack
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method org.aavso.tools.vstar.vela.VeLaInterpreter.getStack() Field org.aavso.tools.vstar.vela.VeLaInterpreter.stack At VeLaInterpreter.java:[line 214]
EI	org.aavso.tools.vstar.vela.VeLaScope.getFunctions() may expose internal representation by returning VeLaScope.functions
	Bug type EI_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.vela.VeLaScope In method org.aavso.tools.vstar.vela.VeLaScope.getFunctions() Field org.aavso.tools.vstar.vela.VeLaScope.functions At VeLaScope.java:[line 45]
EI2	org.aavso.tools.vstar.data.ValidObservation.setMagnitude(Magnitude) may expose internal representation by storing an externally mutable object into ValidObservation.magnitude
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.setMagnitude(Magnitude) Field org.aavso.tools.vstar.data.ValidObservation.magnitude Local variable named magnitude At ValidObservation.java:[line 546]
EI2	new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.ops
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) Field org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.ops Local variable named ops At AbstractObservationFieldMatcher.java:[line 46]
EI2	org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.observationSelectionMessage
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher In method org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) Field org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.observationSelectionMessage Local variable named msg At AbstractObservationFieldMatcher.java:[line 97]
EI2	org.aavso.tools.vstar.data.filter.PhaseFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) may expose internal representation by storing an externally mutable object into PhaseFieldMatcher.observationSelectionMessage
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.data.filter.PhaseFieldMatcher In method org.aavso.tools.vstar.data.filter.PhaseFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) Field org.aavso.tools.vstar.data.filter.PhaseFieldMatcher.observationSelectionMessage Local variable named msg At PhaseFieldMatcher.java:[line 45]
EI2	new org.aavso.tools.vstar.data.validation.CommonTextFormatValidator(String, CsvReader, int, int, String, IFieldInfoSource) may expose internal representation by storing an externally mutable object into CommonTextFormatValidator.lineReader
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.data.validation.CommonTextFormatValidator In method new org.aavso.tools.vstar.data.validation.CommonTextFormatValidator(String, CsvReader, int, int, String, IFieldInfoSource) Field org.aavso.tools.vstar.data.validation.CommonTextFormatValidator.lineReader Local variable named lineReader At CommonTextFormatValidator.java:[line 81]
EI2	new org.aavso.tools.vstar.exception.ObservationValidationWarning(String, ValidObservation) may expose internal representation by storing an externally mutable object into ObservationValidationWarning.ob
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.exception.ObservationValidationWarning In method new org.aavso.tools.vstar.exception.ObservationValidationWarning(String, ValidObservation) Field org.aavso.tools.vstar.exception.ObservationValidationWarning.ob Local variable named ob At ObservationValidationWarning.java:[line 37]
EI2	new org.aavso.tools.vstar.exception.ObservationValidationWarning(ValidObservation) may expose internal representation by storing an externally mutable object into ObservationValidationWarning.ob
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.exception.ObservationValidationWarning In method new org.aavso.tools.vstar.exception.ObservationValidationWarning(ValidObservation) Field org.aavso.tools.vstar.exception.ObservationValidationWarning.ob Local variable named ob At ObservationValidationWarning.java:[line 32]
EI2	new org.aavso.tools.vstar.input.database.AuthenticationTask(List, String, String) may expose internal representation by storing an externally mutable object into AuthenticationTask.authenticators
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.input.database.AuthenticationTask In method new org.aavso.tools.vstar.input.database.AuthenticationTask(List, String, String) Field org.aavso.tools.vstar.input.database.AuthenticationTask.authenticators Local variable named authenticators At AuthenticationTask.java:[line 47]
EI2	new org.aavso.tools.vstar.input.text.ObservationFieldSplitter(CsvReader, int, int) may expose internal representation by storing an externally mutable object into ObservationFieldSplitter.lineReader
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.input.text.ObservationFieldSplitter In method new org.aavso.tools.vstar.input.text.ObservationFieldSplitter(CsvReader, int, int) Field org.aavso.tools.vstar.input.text.ObservationFieldSplitter.lineReader Local variable named lineReader At ObservationFieldSplitter.java:[line 55]
EI2	new org.aavso.tools.vstar.input.text.ObservationSourceAnalyser(LineNumberReader, String) may expose internal representation by storing an externally mutable object into ObservationSourceAnalyser.obsSource
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.input.text.ObservationSourceAnalyser In method new org.aavso.tools.vstar.input.text.ObservationSourceAnalyser(LineNumberReader, String) Field org.aavso.tools.vstar.input.text.ObservationSourceAnalyser.obsSource Local variable named obsSource At ObservationSourceAnalyser.java:[line 57]
EI2	new org.aavso.tools.vstar.input.text.TextFormatObservationReader(LineNumberReader, ObservationSourceAnalyser, String) may expose internal representation by storing an externally mutable object into TextFormatObservationReader.reader
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.input.text.TextFormatObservationReader In method new org.aavso.tools.vstar.input.text.TextFormatObservationReader(LineNumberReader, ObservationSourceAnalyser, String) Field org.aavso.tools.vstar.input.text.TextFormatObservationReader.reader Local variable named reader At TextFormatObservationReader.java:[line 64]
EI2	org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.setInputInfo(List, String) may expose internal representation by storing an externally mutable object into ObservationSourcePluginBase.inputStreams
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.plugin.ObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.setInputInfo(List, String) Field org.aavso.tools.vstar.plugin.ObservationSourcePluginBase.inputStreams Local variable named inputStreams At ObservationSourcePluginBase.java:[line 147]
EI2	org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.setInfo(StarInfo) may expose internal representation by storing an externally mutable object into AIDWebServiceObservationSourcePluginBase.info
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.setInfo(StarInfo) Field org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.info Local variable named info At AIDWebServiceObservationSourcePluginBase.java:[line 318]
EI2	new org.aavso.tools.vstar.plugin.ob.src.impl.NamedNodeMapSequence(NamedNodeMap) may expose internal representation by storing an externally mutable object into NamedNodeMapSequence.nodeMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.NamedNodeMapSequence In method new org.aavso.tools.vstar.plugin.ob.src.impl.NamedNodeMapSequence(NamedNodeMap) Field org.aavso.tools.vstar.plugin.ob.src.impl.NamedNodeMapSequence.nodeMap Local variable named nodeList At NamedNodeMapSequence.java:[line 32]
EI2	new org.aavso.tools.vstar.ui.MenuBar(IMainUI, UIType) may expose internal representation by storing an externally mutable object into MenuBar.parent
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.MenuBar In method new org.aavso.tools.vstar.ui.MenuBar(IMainUI, UIType) Field org.aavso.tools.vstar.ui.MenuBar.parent Local variable named parent At MenuBar.java:[line 238]
EI2	new org.aavso.tools.vstar.ui.NamedComponent(String, Component) may expose internal representation by storing an externally mutable object into NamedComponent.component
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.NamedComponent In method new org.aavso.tools.vstar.ui.NamedComponent(String, Component) Field org.aavso.tools.vstar.ui.NamedComponent.component Local variable named component At NamedComponent.java:[line 36]
EI2	new org.aavso.tools.vstar.ui.NamedComponent(String, Component, String) may expose internal representation by storing an externally mutable object into NamedComponent.component
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.NamedComponent In method new org.aavso.tools.vstar.ui.NamedComponent(String, Component, String) Field org.aavso.tools.vstar.ui.NamedComponent.component Local variable named component At NamedComponent.java:[line 45]
EI2	new org.aavso.tools.vstar.ui.ToolBar(MenuBar) may expose internal representation by storing an externally mutable object into ToolBar.menuBar
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.ToolBar In method new org.aavso.tools.vstar.ui.ToolBar(MenuBar) Field org.aavso.tools.vstar.ui.ToolBar.menuBar Local variable named menuBar At ToolBar.java:[line 123]
EI2	new org.aavso.tools.vstar.ui.dialog.FileExtensionFilter(List) may expose internal representation by storing an externally mutable object into FileExtensionFilter.extensions
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.FileExtensionFilter In method new org.aavso.tools.vstar.ui.dialog.FileExtensionFilter(List) Field org.aavso.tools.vstar.ui.dialog.FileExtensionFilter.extensions Local variable named extensions At FileExtensionFilter.java:[line 40]
EI2	new org.aavso.tools.vstar.ui.dialog.ObservationDetailsDialog(ValidObservation) may expose internal representation by storing an externally mutable object into ObservationDetailsDialog.ob
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.ObservationDetailsDialog In method new org.aavso.tools.vstar.ui.dialog.ObservationDetailsDialog(ValidObservation) Field org.aavso.tools.vstar.ui.dialog.ObservationDetailsDialog.ob Local variable named ob At ObservationDetailsDialog.java:[line 67]
EI2	new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) may expose internal representation by storing an externally mutable object into PlotControlDialog.plotPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.PlotControlDialog In method new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) Field org.aavso.tools.vstar.ui.dialog.PlotControlDialog.plotPane Local variable named plotPane At PlotControlDialog.java:[line 112]
EI2	new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) may expose internal representation by storing an externally mutable object into PlotControlDialog.timeElementsInBinSettingPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.PlotControlDialog In method new org.aavso.tools.vstar.ui.dialog.PlotControlDialog(String, ObservationAndMeanPlotPane, TimeElementsInBinSettingPane, NamedComponent, AnalysisType) Field org.aavso.tools.vstar.ui.dialog.PlotControlDialog.timeElementsInBinSettingPane Local variable named timeElementsInBinSettingPane At PlotControlDialog.java:[line 116]
EI2	new org.aavso.tools.vstar.ui.dialog.SeriesTypeCreationDialog(List) may expose internal representation by storing an externally mutable object into SeriesTypeCreationDialog.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.SeriesTypeCreationDialog In method new org.aavso.tools.vstar.ui.dialog.SeriesTypeCreationDialog(List) Field org.aavso.tools.vstar.ui.dialog.SeriesTypeCreationDialog.obs Local variable named obs At SeriesTypeCreationDialog.java:[line 58]
EI2	new org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane(JTextField, boolean) may expose internal representation by storing an externally mutable object into StarGroupSelectionPane.starField
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane In method new org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane(JTextField, boolean) Field org.aavso.tools.vstar.ui.dialog.StarGroupSelectionPane.starField Local variable named starField At StarGroupSelectionPane.java:[line 84]
EI2	new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) may expose internal representation by storing an externally mutable object into HarmonicInfoDialog.interfaceComponent
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog In method new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) Field org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog.interfaceComponent Local variable named interfaceComponent At HarmonicInfoDialog.java:[line 99]
EI2	new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) may expose internal representation by storing an externally mutable object into HarmonicInfoDialog.msg
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog In method new org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog(HarmonicSearchResultMessage, Component) Field org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog.msg Local variable named msg At HarmonicInfoDialog.java:[line 97]
EI2	new org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog(Component, List, Map, String) may expose internal representation by storing an externally mutable object into HarmonicInputDialog.freqToHarmonics
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog In method new org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog(Component, List, Map, String) Field org.aavso.tools.vstar.ui.dialog.model.HarmonicInputDialog.freqToHarmonics Local variable named freqToHarmonicsMap At HarmonicInputDialog.java:[line 72]
EI2	new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DChartPane.chart
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane In method new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.chart Local variable named chart At PeriodAnalysis2DChartPane.java:[line 95]
EI2	new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DChartPane.model
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane In method new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane(JFreeChart, PeriodAnalysis2DPlotModel, boolean) Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.model Local variable named model At PeriodAnalysis2DChartPane.java:[line 96]
EI2	new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane(PeriodAnalysisDataTableModel, IPeriodAnalysisAlgorithm, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTablePane.model
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane In method new org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane(PeriodAnalysisDataTableModel, IPeriodAnalysisAlgorithm, boolean) Field org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysisDataTablePane.model Local variable named model At PeriodAnalysisDataTablePane.java:[line 93]
EI2	new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZDataTablePane(WWZDataTableModel) may expose internal representation by storing an externally mutable object into WWZDataTablePane.model
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WWZDataTablePane In method new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZDataTablePane(WWZDataTableModel) Field org.aavso.tools.vstar.ui.dialog.period.wwz.WWZDataTablePane.model Local variable named model At WWZDataTablePane.java:[line 80]
EI2	new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) may expose internal representation by storing an externally mutable object into WWZPlotPane.chart
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane In method new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) Field org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.chart Local variable named chart At WWZPlotPane.java:[line 71]
EI2	new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) may expose internal representation by storing an externally mutable object into WWZPlotPane.model
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane In method new org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane(JFreeChart, WWZ2DPlotModel, double, double) Field org.aavso.tools.vstar.ui.dialog.period.wwz.WWZPlotPane.model Local variable named model At WWZPlotPane.java:[line 72]
EI2	new org.aavso.tools.vstar.ui.dialog.period.wwz.WeightedWaveletZTransformResultDialog(String, String, WeightedWaveletZTransform, WWZCoordinateType) may expose internal representation by storing an externally mutable object into WeightedWaveletZTransformResultDialog.wwt
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.period.wwz.WeightedWaveletZTransformResultDialog In method new org.aavso.tools.vstar.ui.dialog.period.wwz.WeightedWaveletZTransformResultDialog(String, String, WeightedWaveletZTransform, WWZCoordinateType) Field org.aavso.tools.vstar.ui.dialog.period.wwz.WeightedWaveletZTransformResultDialog.wwt Local variable named wwt At WeightedWaveletZTransformResultDialog.java:[line 94]
EI2	new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog(PluginManager) may expose internal representation by storing an externally mutable object into PluginManagementDialog.manager
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog In method new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog(PluginManager) Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.manager Local variable named manager At PluginManagementDialog.java:[line 89]
EI2	new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation(PluginManager, String) may expose internal representation by storing an externally mutable object into PluginManagementOperation.manager
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation In method new org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation(PluginManager, String) Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementOperation.manager Local variable named manager At PluginManagementOperation.java:[line 33]
EI2	new org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog(ISeriesInfoProvider, String, JPanel) may expose internal representation by storing an externally mutable object into AbstractSeriesVisibilityDialog.nextPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog In method new org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog(ISeriesInfoProvider, String, JPanel) Field org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.nextPane Local variable named nextPane At AbstractSeriesVisibilityDialog.java:[line 78]
EI2	new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) may expose internal representation by storing an externally mutable object into MeanSourcePane.obsPlotModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane In method new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) Field org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane.obsPlotModel Local variable named obsPlotModel At MeanSourcePane.java:[line 70]
EI2	new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) may expose internal representation by storing an externally mutable object into MeanSourcePane.obsPlotPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane In method new org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane(ObservationAndMeanPlotModel, ObservationAndMeanPlotPane) Field org.aavso.tools.vstar.ui.dialog.series.MeanSourcePane.obsPlotPane Local variable named plotPane At MeanSourcePane.java:[line 71]
EI2	new org.aavso.tools.vstar.ui.dialog.series.MultipleSeriesSelectionDialog(SeriesVisibilityPane) may expose internal representation by storing an externally mutable object into MultipleSeriesSelectionDialog.seriesVisibilityPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.MultipleSeriesSelectionDialog In method new org.aavso.tools.vstar.ui.dialog.series.MultipleSeriesSelectionDialog(SeriesVisibilityPane) Field org.aavso.tools.vstar.ui.dialog.series.MultipleSeriesSelectionDialog.seriesVisibilityPane Local variable named seriesVisibilityPane At MultipleSeriesSelectionDialog.java:[line 67]
EI2	new org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane(ObservationAndMeanPlotModel, AnalysisType, boolean, boolean, boolean) may expose internal representation by storing an externally mutable object into SeriesVisibilityPane.obsPlotModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane In method new org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane(ObservationAndMeanPlotModel, AnalysisType, boolean, boolean, boolean) Field org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.obsPlotModel Local variable named obsPlotModel At SeriesVisibilityPane.java:[line 111]
EI2	new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionDialog(ObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into SingleSeriesSelectionDialog.obsPlotModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionDialog In method new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionDialog(ObservationAndMeanPlotModel) Field org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionDialog.obsPlotModel Local variable named obsPlotModel At SingleSeriesSelectionDialog.java:[line 55]
EI2	new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionPane(ObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into SingleSeriesSelectionPane.obsPlotModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionPane In method new org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionPane(ObservationAndMeanPlotModel) Field org.aavso.tools.vstar.ui.dialog.series.SingleSeriesSelectionPane.obsPlotModel Local variable named obsPlotModel At SingleSeriesSelectionPane.java:[line 54]
EI2	new org.aavso.tools.vstar.ui.mediator.StarInfo(AbstractObservationRetriever, String, String, Double, Double, String, String, String, RAInfo, DecInfo, Integer) may expose internal representation by storing an externally mutable object into StarInfo.retriever
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.StarInfo In method new org.aavso.tools.vstar.ui.mediator.StarInfo(AbstractObservationRetriever, String, String, Double, Double, String, String, String, RAInfo, DecInfo, Integer) Field org.aavso.tools.vstar.ui.mediator.StarInfo.retriever Local variable named retriever At StarInfo.java:[line 76]
EI2	org.aavso.tools.vstar.ui.mediator.StarInfo.setRetriever(AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into StarInfo.retriever
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.StarInfo In method org.aavso.tools.vstar.ui.mediator.StarInfo.setRetriever(AbstractObservationRetriever) Field org.aavso.tools.vstar.ui.mediator.StarInfo.retriever Local variable named retriever At StarInfo.java:[line 178]
EI2	new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.meansListPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.meansListPane Local variable named meansListPane At AnalysisTypeChangeMessage.java:[line 70]
EI2	new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.obsAndMeanChartPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.obsAndMeanChartPane Local variable named obsAndMeanChartPane At AnalysisTypeChangeMessage.java:[line 68]
EI2	new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) may expose internal representation by storing an externally mutable object into AnalysisTypeChangeMessage.obsListPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage In method new org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage(AnalysisType, ObservationAndMeanPlotPane, ObservationListPane, SyntheticObservationListPane, ViewModeType) Field org.aavso.tools.vstar.ui.mediator.message.AnalysisTypeChangeMessage.obsListPane Local variable named obsListPane At AnalysisTypeChangeMessage.java:[line 69]
EI2	new org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage(ValidObservation, Object) may expose internal representation by storing an externally mutable object into DiscrepantObservationMessage.observation
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage In method new org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage(ValidObservation, Object) Field org.aavso.tools.vstar.ui.mediator.message.DiscrepantObservationMessage.observation Local variable named observation At DiscrepantObservationMessage.java:[line 41]
EI2	new org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage(List, Object) may expose internal representation by storing an externally mutable object into ExcludedObservationMessage.observations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage In method new org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage(List, Object) Field org.aavso.tools.vstar.ui.mediator.message.ExcludedObservationMessage.observations Local variable named observations At ExcludedObservationMessage.java:[line 44]
EI2	new org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage(Object, List, IPeriodAnalysisDatum, double) may expose internal representation by storing an externally mutable object into HarmonicSearchResultMessage.harmonics
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage In method new org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage(Object, List, IPeriodAnalysisDatum, double) Field org.aavso.tools.vstar.ui.mediator.message.HarmonicSearchResultMessage.harmonics Local variable named harmonics At HarmonicSearchResultMessage.java:[line 48]
EI2	new org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage(List, Object) may expose internal representation by storing an externally mutable object into MultipleObservationSelectionMessage.observations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage In method new org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage(List, Object) Field org.aavso.tools.vstar.ui.mediator.message.MultipleObservationSelectionMessage.observations Local variable named observations At MultipleObservationSelectionMessage.java:[line 43]
EI2	new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.obs Local variable named obs At NewStarMessage.java:[line 69]
EI2	new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.obsCategoryMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.obsCategoryMap Local variable named obsCategoryMap At NewStarMessage.java:[line 70]
EI2	new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) may expose internal representation by storing an externally mutable object into NewStarMessage.starInfo
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.NewStarMessage In method new org.aavso.tools.vstar.ui.mediator.message.NewStarMessage(NewStarType, StarInfo, List, Map, double, double, String) Field org.aavso.tools.vstar.ui.mediator.message.NewStarMessage.starInfo Local variable named info At NewStarMessage.java:[line 68]
EI2	new org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage(ValidObservation, Object) may expose internal representation by storing an externally mutable object into ObservationSelectionMessage.observation
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage In method new org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage(ValidObservation, Object) Field org.aavso.tools.vstar.ui.mediator.message.ObservationSelectionMessage.observation Local variable named observation At ObservationSelectionMessage.java:[line 41]
EI2	new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.newTopHits
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.newTopHits Local variable named newTopHits At PeriodAnalysisRefinementMessage.java:[line 44]
EI2	new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.refinedData
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.refinedData Local variable named refinedData At PeriodAnalysisRefinementMessage.java:[line 42]
EI2	new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisRefinementMessage.refinedTopHits
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage In method new org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage(Object, Map, Map, List) Field org.aavso.tools.vstar.ui.mediator.message.PeriodAnalysisRefinementMessage.refinedTopHits Local variable named refinedTopHits At PeriodAnalysisRefinementMessage.java:[line 43]
EI2	new org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage(Object, double, double, Map) may expose internal representation by storing an externally mutable object into PhaseChangeMessage.seriesVisibilityMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage In method new org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage(Object, double, double, Map) Field org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.seriesVisibilityMap Local variable named seriesVisibilityMap At PhaseChangeMessage.java:[line 52]
EI2	new org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage(Object, double, double, Map) may expose internal representation by storing an externally mutable object into PhaseSelectionMessage.seriesVisibilityMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage In method new org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage(Object, double, double, Map) Field org.aavso.tools.vstar.ui.mediator.message.PhaseSelectionMessage.seriesVisibilityMap Local variable named seriesVisibilityMap At PhaseSelectionMessage.java:[line 54]
EI2	new org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage(Object, SeriesType, List) may expose internal representation by storing an externally mutable object into SeriesCreationMessage.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage In method new org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage(Object, SeriesType, List) Field org.aavso.tools.vstar.ui.mediator.message.SeriesCreationMessage.obs Local variable named obs At SeriesCreationMessage.java:[line 37]
EI2	new org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage(Object, Set) may expose internal representation by storing an externally mutable object into SeriesVisibilityChangeMessage.visibleSeries
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage In method new org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage(Object, Set) Field org.aavso.tools.vstar.ui.mediator.message.SeriesVisibilityChangeMessage.visibleSeries Local variable named visibleSeries At SeriesVisibilityChangeMessage.java:[line 41]
EI2	new org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel(List) may expose internal representation by storing an externally mutable object into AbstractSyntheticObservationTableModel.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel In method new org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel(List) Field org.aavso.tools.vstar.ui.model.list.AbstractSyntheticObservationTableModel.obs Local variable named obs At AbstractSyntheticObservationTableModel.java:[line 36]
EI2	new org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel(List) may expose internal representation by storing an externally mutable object into InvalidObservationTableModel.invalidObservations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel In method new org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel(List) Field org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.invalidObservations Local variable named invalidObservations At InvalidObservationTableModel.java:[line 47]
EI2	new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.columnTypes
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel In method new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) Field org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.columnTypes Local variable named columnTypes At PeriodAnalysisDataTableModel.java:[line 50]
EI2	new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.data
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel In method new org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel(PeriodAnalysisCoordinateType[], Map) Field org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.data Local variable named data At PeriodAnalysisDataTableModel.java:[line 51]
EI2	org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.setData(Map) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataTableModel.data
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel In method org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.setData(Map) Field org.aavso.tools.vstar.ui.model.list.PeriodAnalysisDataTableModel.data Local variable named data At PeriodAnalysisDataTableModel.java:[line 71]
EI2	new org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel(Map, List, ITableColumnInfoSource) may expose internal representation by storing an externally mutable object into ValidObservationTableModel.obsSourceListMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel In method new org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel(Map, List, ITableColumnInfoSource) Field org.aavso.tools.vstar.ui.model.list.ValidObservationTableModel.obsSourceListMap Local variable named obsSourceListMap At ValidObservationTableModel.java:[line 87]
EI2	new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) may expose internal representation by storing an externally mutable object into WWZDataTableModel.stats
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.WWZDataTableModel In method new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) Field org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.stats Local variable named stats At WWZDataTableModel.java:[line 51]
EI2	new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) may expose internal representation by storing an externally mutable object into WWZDataTableModel.wwt
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.list.WWZDataTableModel In method new org.aavso.tools.vstar.ui.model.list.WWZDataTableModel(List, WeightedWaveletZTransform) Field org.aavso.tools.vstar.ui.model.list.WWZDataTableModel.wwt Local variable named wwt At WWZDataTableModel.java:[line 52]
EI2	new org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction(UnivariateRealFunction, List, double, ICoordSource) may expose internal representation by storing an externally mutable object into ContinuousModelFunction.fit
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction In method new org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction(UnivariateRealFunction, List, double, ICoordSource) Field org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.fit Local variable named fit At ContinuousModelFunction.java:[line 57]
EI2	org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.setPpModel(PhasedObservationAndMeanPlotModel) may expose internal representation by storing an externally mutable object into ContinuousModelFunction.ppModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction In method org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.setPpModel(PhasedObservationAndMeanPlotModel) Field org.aavso.tools.vstar.ui.model.plot.ContinuousModelFunction.ppModel Local variable named ppModel At ContinuousModelFunction.java:[line 95]
EI2	new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction) may expose internal representation by storing an externally mutable object into ContinuousModelPlotModel.modelFunction
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction) Field org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel.modelFunction Local variable named modelFunction At ContinuousModelPlotModel.java:[line 52]
EI2	new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) may expose internal representation by storing an externally mutable object into ObservationAndMeanPlotModel.timeElementEntity
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map) Field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.timeElementEntity Local variable named timeElementEntity At ObservationAndMeanPlotModel.java:[line 105]
EI2	new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) may expose internal representation by storing an externally mutable object into PeriodAnalysis2DPlotModel.analysisValues
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel In method new org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel(Map, PeriodAnalysisCoordinateType, PeriodAnalysisCoordinateType, boolean) Field org.aavso.tools.vstar.ui.model.plot.PeriodAnalysis2DPlotModel.analysisValues Local variable named analysisValues At PeriodAnalysis2DPlotModel.java:[line 60]
EI2	new org.aavso.tools.vstar.ui.model.plot.PhasedObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map, ContinuousModelFunction, int) may expose internal representation by storing an externally mutable object into PhasedObservationAndMeanPlotModel.modelFunction
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.PhasedObservationAndMeanPlotModel In method new org.aavso.tools.vstar.ui.model.plot.PhasedObservationAndMeanPlotModel(Map, ICoordSource, Comparator, ITimeElementEntity, Map, ContinuousModelFunction, int) Field org.aavso.tools.vstar.ui.model.plot.PhasedObservationAndMeanPlotModel.modelFunction Local variable named modelFunction At PhasedObservationAndMeanPlotModel.java:[line 71]
EI2	new org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel(List, WWZCoordinateType, WWZCoordinateType) may expose internal representation by storing an externally mutable object into WWZ2DPlotModel.stats
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel In method new org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel(List, WWZCoordinateType, WWZCoordinateType) Field org.aavso.tools.vstar.ui.model.plot.WWZ2DPlotModel.stats Local variable named stats At WWZ2DPlotModel.java:[line 49]
EI2	new org.aavso.tools.vstar.ui.pane.list.ListSearchPane(AbstractTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into ListSearchPane.rowSorter
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.ListSearchPane In method new org.aavso.tools.vstar.ui.pane.list.ListSearchPane(AbstractTableModel, TableRowSorter) Field org.aavso.tools.vstar.ui.pane.list.ListSearchPane.rowSorter Local variable named rowSorter At ListSearchPane.java:[line 64]
EI2	new org.aavso.tools.vstar.ui.pane.list.ObservationListPane(String, ValidObservationTableModel, InvalidObservationTableModel, boolean, Set, AnalysisType) may expose internal representation by storing an externally mutable object into ObservationListPane.validDataModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.ObservationListPane In method new org.aavso.tools.vstar.ui.pane.list.ObservationListPane(String, ValidObservationTableModel, InvalidObservationTableModel, boolean, Set, AnalysisType) Field org.aavso.tools.vstar.ui.pane.list.ObservationListPane.validDataModel Local variable named validDataModel At ObservationListPane.java:[line 126]
EI2	new org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane(AbstractSyntheticObservationTableModel, String) may expose internal representation by storing an externally mutable object into SyntheticObservationListPane.obsTableModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane In method new org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane(AbstractSyntheticObservationTableModel, String) Field org.aavso.tools.vstar.ui.pane.list.SyntheticObservationListPane.obsTableModel Local variable named obsTableModel At SyntheticObservationListPane.java:[line 61]
EI2	new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into VeLaListSearchPane.model
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane In method new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) Field org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane.model Local variable named model At VeLaListSearchPane.java:[line 64]
EI2	new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) may expose internal representation by storing an externally mutable object into VeLaListSearchPane.rowSorter
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane In method new org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane(ValidObservationTableModel, TableRowSorter) Field org.aavso.tools.vstar.ui.pane.list.VeLaListSearchPane.rowSorter Local variable named rowSorter At VeLaListSearchPane.java:[line 69]
EI2	new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) may expose internal representation by storing an externally mutable object into VisibleSeriesRowFilter.tableModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter In method new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) Field org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter.tableModel Local variable named tableModel At VisibleSeriesRowFilter.java:[line 63]
EI2	new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) may expose internal representation by storing an externally mutable object into VisibleSeriesRowFilter.visibleSeries
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter In method new org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter(ValidObservationTableModel, Set, AnalysisType) Field org.aavso.tools.vstar.ui.pane.list.VisibleSeriesRowFilter.visibleSeries Local variable named visibleSeries At VisibleSeriesRowFilter.java:[line 64]
EI2	new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.bounds
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.bounds Local variable named bounds At AbstractObservationPlotPane.java:[line 137]
EI2	new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.obsModel
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsModel Local variable named obsModel At AbstractObservationPlotPane.java:[line 135]
EI2	new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) may expose internal representation by storing an externally mutable object into AbstractObservationPlotPane.retriever
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method new org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane(String, String, String, String, ObservationAndMeanPlotModel, Dimension, AbstractObservationRetriever) Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.retriever Local variable named retriever At AbstractObservationPlotPane.java:[line 139]
EI2	new org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane(String, String, Dimension, double, double, AbstractObservationRetriever, PhasedObservationAndMeanPlotModel[]) may expose internal representation by storing an externally mutable object into PhaseAndMeanPlotPane.obsAndMeanModels
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane In method new org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane(String, String, Dimension, double, double, AbstractObservationRetriever, PhasedObservationAndMeanPlotModel[]) Field org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.obsAndMeanModels Local variable named obsAndMeanModels At PhaseAndMeanPlotPane.java:[line 91]
EI2	new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) may expose internal representation by storing an externally mutable object into TimeElementsInBinSettingPane.plotPane
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane In method new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) Field org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane.plotPane Local variable named plotPane At TimeElementsInBinSettingPane.java:[line 72]
EI2	new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) may expose internal representation by storing an externally mutable object into TimeElementsInBinSettingPane.timeElementEntity
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane In method new org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane(String, ObservationAndMeanPlotPane, ITimeElementEntity) Field org.aavso.tools.vstar.ui.pane.plot.TimeElementsInBinSettingPane.timeElementEntity Local variable named timeElementEntity At TimeElementsInBinSettingPane.java:[line 73]
EI2	new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask(ObservationSourcePluginBase) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginTask.obSourcePlugin
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask In method new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask(ObservationSourcePluginBase) Field org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.obSourcePlugin Local variable named obSourcePlugin At NewStarFromObSourcePluginTask.java:[line 77]
EI2	new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask(ObservationSourcePluginBase, File, boolean) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginWithSuppliedFileTask.obSourcePlugin
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask In method new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask(ObservationSourcePluginBase, File, boolean) Field org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.obSourcePlugin Local variable named obSourcePlugin At NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 68]
EI2	new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask(ObservationSourcePluginBase, URL, boolean) may expose internal representation by storing an externally mutable object into NewStarFromObSourcePluginWithSuppliedURLTask.obSourcePlugin
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask In method new org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask(ObservationSourcePluginBase, URL, boolean) Field org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask.obSourcePlugin Local variable named obSourcePlugin At NewStarFromObSourcePluginWithSuppliedURLTask.java:[line 68]
EI2	new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) may expose internal representation by storing an externally mutable object into ObsListFileSaveTask.observations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.ObsListFileSaveTask In method new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) Field org.aavso.tools.vstar.ui.task.ObsListFileSaveTask.observations Local variable named observations At ObsListFileSaveTask.java:[line 58]
EI2	new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) may expose internal representation by storing an externally mutable object into ObsListFileSaveTask.plugin
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.ObsListFileSaveTask In method new org.aavso.tools.vstar.ui.task.ObsListFileSaveTask(ObservationSinkPluginBase, List, File, String) Field org.aavso.tools.vstar.ui.task.ObsListFileSaveTask.plugin Local variable named plugin At ObsListFileSaveTask.java:[line 57]
EI2	new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisTask.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.PeriodAnalysisTask In method new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) Field org.aavso.tools.vstar.ui.task.PeriodAnalysisTask.obs Local variable named obs At PeriodAnalysisTask.java:[line 66]
EI2	new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) may expose internal representation by storing an externally mutable object into PeriodAnalysisTask.periodAnalysisPlugin
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.PeriodAnalysisTask In method new org.aavso.tools.vstar.ui.task.PeriodAnalysisTask(PeriodAnalysisPluginBase, SeriesType, List) Field org.aavso.tools.vstar.ui.task.PeriodAnalysisTask.periodAnalysisPlugin Local variable named plugin At PeriodAnalysisTask.java:[line 64]
EI2	new org.aavso.tools.vstar.ui.task.PhasePlotTask(double, double, Map) may expose internal representation by storing an externally mutable object into PhasePlotTask.seriesVisibilityMap
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.task.PhasePlotTask In method new org.aavso.tools.vstar.ui.task.PhasePlotTask(double, double, Map) Field org.aavso.tools.vstar.ui.task.PhasePlotTask.seriesVisibilityMap Local variable named seriesVisibilityMap At PhasePlotTask.java:[line 53]
EI2	new org.aavso.tools.vstar.ui.undo.ObservationExclusionAction(List, boolean) may expose internal representation by storing an externally mutable object into ObservationExclusionAction.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.ui.undo.ObservationExclusionAction In method new org.aavso.tools.vstar.ui.undo.ObservationExclusionAction(List, boolean) Field org.aavso.tools.vstar.ui.undo.ObservationExclusionAction.obs Local variable named obs At ObservationExclusionAction.java:[line 46]
EI2	new org.aavso.tools.vstar.util.AbstractExtremaFinder(List, UnivariateRealFunction, ICoordSource, double) may expose internal representation by storing an externally mutable object into AbstractExtremaFinder.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.AbstractExtremaFinder In method new org.aavso.tools.vstar.util.AbstractExtremaFinder(List, UnivariateRealFunction, ICoordSource, double) Field org.aavso.tools.vstar.util.AbstractExtremaFinder.obs Local variable named obs At AbstractExtremaFinder.java:[line 43]
EI2	new org.aavso.tools.vstar.util.TSBase(List) may expose internal representation by storing an externally mutable object into TSBase.observations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.TSBase In method new org.aavso.tools.vstar.util.TSBase(List) Field org.aavso.tools.vstar.util.TSBase.observations Local variable named observations At TSBase.java:[line 107]
EI2	new org.aavso.tools.vstar.util.model.AbstractModel(List) may expose internal representation by storing an externally mutable object into AbstractModel.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.model.AbstractModel In method new org.aavso.tools.vstar.util.model.AbstractModel(List) Field org.aavso.tools.vstar.util.model.AbstractModel.obs Local variable named obs At AbstractModel.java:[line 72] Another occurrence at AbstractModel.java:[line 83]
EI2	new org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel(PeriodAnalysisDataPoint, List, IPeriodAnalysisAlgorithm) may expose internal representation by storing an externally mutable object into PeriodAnalysisDerivedMultiPeriodicModel.harmonics
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel In method new org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel(PeriodAnalysisDataPoint, List, IPeriodAnalysisAlgorithm) Field org.aavso.tools.vstar.util.model.PeriodAnalysisDerivedMultiPeriodicModel.harmonics Local variable named harmonics At PeriodAnalysisDerivedMultiPeriodicModel.java:[line 71]
EI2	new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) may expose internal representation by storing an externally mutable object into WWZMultiperiodicModel.periods
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.model.WWZMultiperiodicModel In method new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) Field org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.periods Local variable named periods At WWZMultiperiodicModel.java:[line 65]
EI2	new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) may expose internal representation by storing an externally mutable object into WWZMultiperiodicModel.wwt
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.model.WWZMultiperiodicModel In method new org.aavso.tools.vstar.util.model.WWZMultiperiodicModel(WeightedWaveletZTransform, List) Field org.aavso.tools.vstar.util.model.WWZMultiperiodicModel.wwt Local variable named wwt At WWZMultiperiodicModel.java:[line 64]
EI2	new org.aavso.tools.vstar.util.notification.ListChangeMessage(ListChangeType, List, int, Object) may expose internal representation by storing an externally mutable object into ListChangeMessage.source
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.notification.ListChangeMessage In method new org.aavso.tools.vstar.util.notification.ListChangeMessage(ListChangeType, List, int, Object) Field org.aavso.tools.vstar.util.notification.ListChangeMessage.source Local variable named source At ListChangeMessage.java:[line 43]
EI2	new org.aavso.tools.vstar.util.notification.NotifyingArrayList(ArrayList) may expose internal representation by storing an externally mutable object into NotifyingArrayList.list
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.notification.NotifyingArrayList In method new org.aavso.tools.vstar.util.notification.NotifyingArrayList(ArrayList) Field org.aavso.tools.vstar.util.notification.NotifyingArrayList.list Local variable named otherList At NotifyingArrayList.java:[line 58]
EI2	new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) may expose internal representation by storing an externally mutable object into PeriodAnalysisDataPoint.coordTypes
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method new org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint(PeriodAnalysisCoordinateType[], double[]) Field org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.coordTypes Local variable named coordTypes At PeriodAnalysisDataPoint.java:[line 47]
EI2	new org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform(List, double, double) may expose internal representation by storing an externally mutable object into WeightedWaveletZTransform.obs
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method new org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform(List, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.obs Local variable named observations At WeightedWaveletZTransform.java:[line 121]
EI2	new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) may expose internal representation by storing an externally mutable object into ApplicationProperties.frame
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.property.ApplicationProperties In method new org.aavso.tools.vstar.util.property.ApplicationProperties(MainFrame) Field org.aavso.tools.vstar.util.property.ApplicationProperties.frame Local variable named frame At ApplicationProperties.java:[line 80]
EI2	new org.aavso.tools.vstar.util.stats.Bin(ValidObservation, double[]) may expose internal representation by storing an externally mutable object into Bin.magnitudes
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.stats.Bin In method new org.aavso.tools.vstar.util.stats.Bin(ValidObservation, double[]) Field org.aavso.tools.vstar.util.stats.Bin.magnitudes Local variable named magnitudeBin At Bin.java:[line 40]
EI2	new org.aavso.tools.vstar.util.stats.Bin(ValidObservation, double[]) may expose internal representation by storing an externally mutable object into Bin.meanObservation
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.stats.Bin In method new org.aavso.tools.vstar.util.stats.Bin(ValidObservation, double[]) Field org.aavso.tools.vstar.util.stats.Bin.meanObservation Local variable named meanObservation At Bin.java:[line 39]
EI2	new org.aavso.tools.vstar.util.stats.BinningResult(SeriesType, int, List, List) may expose internal representation by storing an externally mutable object into BinningResult.magnitudeBins
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.stats.BinningResult In method new org.aavso.tools.vstar.util.stats.BinningResult(SeriesType, int, List, List) Field org.aavso.tools.vstar.util.stats.BinningResult.magnitudeBins Local variable named magnitudeBins At BinningResult.java:[line 62]
EI2	new org.aavso.tools.vstar.util.stats.BinningResult(SeriesType, int, List, List) may expose internal representation by storing an externally mutable object into BinningResult.meanObservations
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.util.stats.BinningResult In method new org.aavso.tools.vstar.util.stats.BinningResult(SeriesType, int, List, List) Field org.aavso.tools.vstar.util.stats.BinningResult.meanObservations Local variable named meanObservations At BinningResult.java:[line 61]
EI2	new org.aavso.tools.vstar.vela.AST(String, Operand) may expose internal representation by storing an externally mutable object into AST.literal
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.AST In method new org.aavso.tools.vstar.vela.AST(String, Operand) Field org.aavso.tools.vstar.vela.AST.literal Local variable named literal At AST.java:[line 55]
EI2	new org.aavso.tools.vstar.vela.ExpressionVisitor(VeLaInterpreter) may expose internal representation by storing an externally mutable object into ExpressionVisitor.interpreter
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.ExpressionVisitor In method new org.aavso.tools.vstar.vela.ExpressionVisitor(VeLaInterpreter) Field org.aavso.tools.vstar.vela.ExpressionVisitor.interpreter Local variable named interpreter At ExpressionVisitor.java:[line 65]
EI2	new org.aavso.tools.vstar.vela.FunctionExecutor(Optional, List, List, Optional, Optional) may expose internal representation by storing an externally mutable object into FunctionExecutor.parameterNames
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor In method new org.aavso.tools.vstar.vela.FunctionExecutor(Optional, List, List, Optional, Optional) Field org.aavso.tools.vstar.vela.FunctionExecutor.parameterNames Local variable named parameterNames At FunctionExecutor.java:[line 71]
EI2	new org.aavso.tools.vstar.vela.FunctionExecutor(Optional, List, List, Optional, Optional) may expose internal representation by storing an externally mutable object into FunctionExecutor.parameterTypes
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor In method new org.aavso.tools.vstar.vela.FunctionExecutor(Optional, List, List, Optional, Optional) Field org.aavso.tools.vstar.vela.FunctionExecutor.parameterTypes Local variable named parameterTypes At FunctionExecutor.java:[line 72]
EI2	new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional) may expose internal representation by storing an externally mutable object into JavaMethodExecutor.method
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.JavaMethodExecutor In method new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional) Field org.aavso.tools.vstar.vela.JavaMethodExecutor.method Local variable named method At JavaMethodExecutor.java:[line 50]
EI2	new org.aavso.tools.vstar.vela.Operand(Type, List) may expose internal representation by storing an externally mutable object into Operand.listVal
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.Operand In method new org.aavso.tools.vstar.vela.Operand(Type, List) Field org.aavso.tools.vstar.vela.Operand.listVal Local variable named value At Operand.java:[line 70]
EI2	new org.aavso.tools.vstar.vela.Operand(Type, FunctionExecutor) may expose internal representation by storing an externally mutable object into Operand.functionVal
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.Operand In method new org.aavso.tools.vstar.vela.Operand(Type, FunctionExecutor) Field org.aavso.tools.vstar.vela.Operand.functionVal Local variable named value At Operand.java:[line 75]
EI2	org.aavso.tools.vstar.vela.Operand.setFunctionVal(FunctionExecutor) may expose internal representation by storing an externally mutable object into Operand.functionVal
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.Operand In method org.aavso.tools.vstar.vela.Operand.setFunctionVal(FunctionExecutor) Field org.aavso.tools.vstar.vela.Operand.functionVal Local variable named functionVal At Operand.java:[line 177]
EI2	org.aavso.tools.vstar.vela.Operand.setListVal(List) may expose internal representation by storing an externally mutable object into Operand.listVal
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.Operand In method org.aavso.tools.vstar.vela.Operand.setListVal(List) Field org.aavso.tools.vstar.vela.Operand.listVal Local variable named listVal At Operand.java:[line 163]
EI2	new org.aavso.tools.vstar.vela.UserDefinedFunctionExecutor(VeLaInterpreter, Optional, List, List, Optional, Optional, Optional) may expose internal representation by storing an externally mutable object into UserDefinedFunctionExecutor.vela
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.UserDefinedFunctionExecutor In method new org.aavso.tools.vstar.vela.UserDefinedFunctionExecutor(VeLaInterpreter, Optional, List, List, Optional, Optional, Optional) Field org.aavso.tools.vstar.vela.UserDefinedFunctionExecutor.vela Local variable named vela At UserDefinedFunctionExecutor.java:[line 48]
EI2	new org.aavso.tools.vstar.vela.VeLaEnvironment(Map, Set) may expose internal representation by storing an externally mutable object into VeLaEnvironment.cache
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.VeLaEnvironment In method new org.aavso.tools.vstar.vela.VeLaEnvironment(Map, Set) Field org.aavso.tools.vstar.vela.VeLaEnvironment.cache Local variable named map At VeLaEnvironment.java:[line 50]
EI2	new org.aavso.tools.vstar.vela.VeLaEnvironment(Map, Set) may expose internal representation by storing an externally mutable object into VeLaEnvironment.constants
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.VeLaEnvironment In method new org.aavso.tools.vstar.vela.VeLaEnvironment(Map, Set) Field org.aavso.tools.vstar.vela.VeLaEnvironment.constants Local variable named isBoundConstants At VeLaEnvironment.java:[line 51]
EI2	new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean, boolean, List) may expose internal representation by storing an externally mutable object into VeLaInterpreter.sourceDirectories
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method new org.aavso.tools.vstar.vela.VeLaInterpreter(boolean, boolean, List) Field org.aavso.tools.vstar.vela.VeLaInterpreter.sourceDirectories Local variable named sourceDirectories At VeLaInterpreter.java:[line 87]
EI2	new org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment(ValidObservation) may expose internal representation by storing an externally mutable object into VeLaValidObservationEnvironment.ob
	Bug type EI_EXPOSE_REP2 (click for details) In class org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment In method new org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment(ValidObservation) Field org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment.ob Local variable named ob At VeLaValidObservationEnvironment.java:[line 51]
MS	Public static org.aavso.tools.vstar.data.SeriesType.getSeriesColorChangeNotifier() may expose internal representation by returning SeriesType.seriesColorChangeNotifier
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.SeriesType In method org.aavso.tools.vstar.data.SeriesType.getSeriesColorChangeNotifier() Field org.aavso.tools.vstar.data.SeriesType.seriesColorChangeNotifier At SeriesType.java:[line 219]
MS	Public static org.aavso.tools.vstar.data.SeriesType.getSeriesSizeChangeNotifier() may expose internal representation by returning SeriesType.seriesSizeChangeNotifier
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.SeriesType In method org.aavso.tools.vstar.data.SeriesType.getSeriesSizeChangeNotifier() Field org.aavso.tools.vstar.data.SeriesType.seriesSizeChangeNotifier At SeriesType.java:[line 226]
MS	Public static org.aavso.tools.vstar.data.SeriesType.values() may expose internal representation by returning SeriesType.values
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.SeriesType In method org.aavso.tools.vstar.data.SeriesType.values() Field org.aavso.tools.vstar.data.SeriesType.values At SeriesType.java:[line 727]
MS	Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTitles() may expose internal representation by returning ValidObservation.detailTitles
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.getDetailTitles() Field org.aavso.tools.vstar.data.ValidObservation.detailTitles At ValidObservation.java:[line 351]
MS	Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTypes() may expose internal representation by returning ValidObservation.detailTypes
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.getDetailTypes() Field org.aavso.tools.vstar.data.ValidObservation.detailTypes At ValidObservation.java:[line 358]
MS	Public static org.aavso.tools.vstar.data.ValidObservation.getStandardDetailKeys() may expose internal representation by returning ValidObservation.standardDetailKeys
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.getStandardDetailKeys() Field org.aavso.tools.vstar.data.ValidObservation.standardDetailKeys At ValidObservation.java:[line 517]
MS	org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.ops should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.data.filter.DoubleFieldMatcher Field org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.ops At DoubleFieldMatcher.java:[line 28]
MS	org.aavso.tools.vstar.data.filter.ObservationFilter.MATCHERS is a mutable collection
	Bug type MS_MUTABLE_COLLECTION (click for details) In class org.aavso.tools.vstar.data.filter.ObservationFilter Field org.aavso.tools.vstar.data.filter.ObservationFilter.MATCHERS At ObservationFilter.java:[line 42]
MS	org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.DELIMS is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase Field org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.DELIMS At CommonTextFormatSinkPluginBase.java:[line 34]
MS	org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.SUFFIXES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase Field org.aavso.tools.vstar.plugin.ob.sink.impl.CommonTextFormatSinkPluginBase.SUFFIXES At CommonTextFormatSinkPluginBase.java:[line 39]
MS	Public static org.aavso.tools.vstar.scripting.ScriptRunner.getInstance() may expose internal representation by returning ScriptRunner.instance
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.scripting.ScriptRunner In method org.aavso.tools.vstar.scripting.ScriptRunner.getInstance() Field org.aavso.tools.vstar.scripting.ScriptRunner.instance At ScriptRunner.java:[line 71]
MS	Public static org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance() may expose internal representation by returning VStarScriptingAPI.instance
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.scripting.VStarScriptingAPI In method org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance() Field org.aavso.tools.vstar.scripting.VStarScriptingAPI.instance At VStarScriptingAPI.java:[line 98]
MS	org.aavso.tools.vstar.ui.MenuBar.minimalUIExclusions is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.ui.MenuBar Field org.aavso.tools.vstar.ui.MenuBar.minimalUIExclusions At MenuBar.java:[line 144]
MS	org.aavso.tools.vstar.ui.VStar.LOGGER isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.VStar Field org.aavso.tools.vstar.ui.VStar.LOGGER At VStar.java:[line 58]
MS	Public static org.aavso.tools.vstar.ui.dialog.StarSelectorDialog.getInstance() may expose internal representation by returning StarSelectorDialog.instance
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.StarSelectorDialog In method org.aavso.tools.vstar.ui.dialog.StarSelectorDialog.getInstance() Field org.aavso.tools.vstar.ui.dialog.StarSelectorDialog.instance At StarSelectorDialog.java:[line 676]
MS	Public static org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog.getInstance() may expose internal representation by returning PreferencesDialog.instance
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog In method org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog.getInstance() Field org.aavso.tools.vstar.ui.dialog.prefs.PreferencesDialog.instance At PreferencesDialog.java:[line 139]
MS	Public static org.aavso.tools.vstar.ui.mediator.Mediator.getInstance() may expose internal representation by returning Mediator.mediator
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getInstance() Field org.aavso.tools.vstar.ui.mediator.Mediator.mediator At Mediator.java:[line 369]
MS	Public static org.aavso.tools.vstar.ui.mediator.Mediator.getUI() may expose internal representation by returning Mediator.ui
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.getUI() Field org.aavso.tools.vstar.ui.mediator.Mediator.ui At Mediator.java:[line 380]
MS	org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.BUSY_PROGRESS isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ProgressInfo Field org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.BUSY_PROGRESS At ProgressInfo.java:[line 44]
MS	org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.CLEAR_PROGRESS isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ProgressInfo Field org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.CLEAR_PROGRESS At ProgressInfo.java:[line 41]
MS	org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.COMPLETE_PROGRESS isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ProgressInfo Field org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.COMPLETE_PROGRESS At ProgressInfo.java:[line 38]
MS	org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.INCREMENT_PROGRESS isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ProgressInfo Field org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.INCREMENT_PROGRESS At ProgressInfo.java:[line 35]
MS	org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.START_PROGRESS isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.mediator.message.ProgressInfo Field org.aavso.tools.vstar.ui.mediator.message.ProgressInfo.START_PROGRESS At ProgressInfo.java:[line 32]
MS	org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource Field org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.COLUMN_NAMES At AAVSOFormatRawDataColumnInfoSource.java:[line 92]
MS	org.aavso.tools.vstar.ui.model.list.ArbitraryFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.ui.model.list.ArbitraryFormatRawDataColumnInfoSource Field org.aavso.tools.vstar.ui.model.list.ArbitraryFormatRawDataColumnInfoSource.COLUMN_NAMES At ArbitraryFormatRawDataColumnInfoSource.java:[line 55]
MS	org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.COLUMN_NAMES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource Field org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.COLUMN_NAMES At SimpleFormatRawDataColumnInfoSource.java:[line 51]
MS	org.aavso.tools.vstar.ui.model.plot.JDCoordSource.instance isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.model.plot.JDCoordSource Field org.aavso.tools.vstar.ui.model.plot.JDCoordSource.instance At JDCoordSource.java:[line 30]
MS	org.aavso.tools.vstar.ui.model.plot.PreviousCyclePhaseCoordSource.instance isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.model.plot.PreviousCyclePhaseCoordSource Field org.aavso.tools.vstar.ui.model.plot.PreviousCyclePhaseCoordSource.instance At PreviousCyclePhaseCoordSource.java:[line 30]
MS	org.aavso.tools.vstar.ui.model.plot.StandardPhaseCoordSource.instance isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.model.plot.StandardPhaseCoordSource Field org.aavso.tools.vstar.ui.model.plot.StandardPhaseCoordSource.instance At StandardPhaseCoordSource.java:[line 30]
MS	org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.PHASE isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane Field org.aavso.tools.vstar.ui.pane.plot.PhaseAndMeanPlotPane.PHASE At PhaseAndMeanPlotPane.java:[line 53]
MS	Public static org.aavso.tools.vstar.ui.resources.ResourceAccessor.getLoginInfo() may expose internal representation by returning ResourceAccessor.loginInfo
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.resources.ResourceAccessor In method org.aavso.tools.vstar.ui.resources.ResourceAccessor.getLoginInfo() Field org.aavso.tools.vstar.ui.resources.ResourceAccessor.loginInfo At ResourceAccessor.java:[line 52]
MS	Public static org.aavso.tools.vstar.ui.resources.StarGroups.getInstance() may expose internal representation by returning StarGroups.instance
	Bug type MS_EXPOSE_REP (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method org.aavso.tools.vstar.ui.resources.StarGroups.getInstance() Field org.aavso.tools.vstar.ui.resources.StarGroups.instance At StarGroups.java:[line 55]
MS	org.aavso.tools.vstar.util.comparator.JDComparator.instance isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.util.comparator.JDComparator Field org.aavso.tools.vstar.util.comparator.JDComparator.instance At JDComparator.java:[line 30]
MS	org.aavso.tools.vstar.util.notification.ListChangeMessage.NONE isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.util.notification.ListChangeMessage Field org.aavso.tools.vstar.util.notification.ListChangeMessage.NONE At ListChangeMessage.java:[line 26]
MS	org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.DCDFT_COORD_TYPES should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint Field org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.DCDFT_COORD_TYPES At PeriodAnalysisDataPoint.java:[line 32]
MS	org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MAX_PNG_SCALE_FACTOR isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs Field org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MAX_PNG_SCALE_FACTOR At ChartPropertiesPrefs.java:[line 30]
MS	org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MIN_PNG_SCALE_FACTOR isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs Field org.aavso.tools.vstar.util.prefs.ChartPropertiesPrefs.MIN_PNG_SCALE_FACTOR At ChartPropertiesPrefs.java:[line 29]
MS	org.aavso.tools.vstar.util.stats.PhaseCalcs.epochStrategyMap isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.util.stats.PhaseCalcs Field org.aavso.tools.vstar.util.stats.PhaseCalcs.epochStrategyMap At PhaseCalcs.java:[line 39]
MS	org.aavso.tools.vstar.vela.FunctionExecutor.ANY_FORMAL_NAMES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor Field org.aavso.tools.vstar.vela.FunctionExecutor.ANY_FORMAL_NAMES At FunctionExecutor.java:[line 36]
MS	org.aavso.tools.vstar.vela.FunctionExecutor.ANY_FORMAL_TYPES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor Field org.aavso.tools.vstar.vela.FunctionExecutor.ANY_FORMAL_TYPES At FunctionExecutor.java:[line 35]
MS	org.aavso.tools.vstar.vela.FunctionExecutor.NO_FORMAL_NAMES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor Field org.aavso.tools.vstar.vela.FunctionExecutor.NO_FORMAL_NAMES At FunctionExecutor.java:[line 38]
MS	org.aavso.tools.vstar.vela.FunctionExecutor.NO_FORMAL_TYPES is a mutable collection which should be package protected
	Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.FunctionExecutor Field org.aavso.tools.vstar.vela.FunctionExecutor.NO_FORMAL_TYPES At FunctionExecutor.java:[line 39]
MS	org.aavso.tools.vstar.vela.Operand.EMPTY_LIST isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.vela.Operand Field org.aavso.tools.vstar.vela.Operand.EMPTY_LIST At Operand.java:[line 44]
MS	org.aavso.tools.vstar.vela.Operand.NO_VALUE isn't final but should be
	Bug type MS_SHOULD_BE_FINAL (click for details) In class org.aavso.tools.vstar.vela.Operand Field org.aavso.tools.vstar.vela.Operand.NO_VALUE At Operand.java:[line 46]
MS	org.aavso.tools.vstar.vela.VeLaLexer.modeNames should be both final and package protected
	Bug type MS_FINAL_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaLexer Field org.aavso.tools.vstar.vela.VeLaLexer.modeNames At VeLaLexer.java:[line 28]
MS	org.aavso.tools.vstar.vela.VeLaLexer._decisionToDFA should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaLexer Field org.aavso.tools.vstar.vela.VeLaLexer._decisionToDFA At VeLaLexer.java:[line 281]
MS	org.aavso.tools.vstar.vela.VeLaLexer.ruleNames should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaLexer Field org.aavso.tools.vstar.vela.VeLaLexer.ruleNames At VeLaLexer.java:[line 32]
MS	org.aavso.tools.vstar.vela.VeLaLexer.tokenNames should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaLexer Field org.aavso.tools.vstar.vela.VeLaLexer.tokenNames At VeLaLexer.java:[line 67]
MS	org.aavso.tools.vstar.vela.VeLaParser._decisionToDFA should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser Field org.aavso.tools.vstar.vela.VeLaParser._decisionToDFA At VeLaParser.java:[line 2335]
MS	org.aavso.tools.vstar.vela.VeLaParser.ruleNames should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser Field org.aavso.tools.vstar.vela.VeLaParser.ruleNames At VeLaParser.java:[line 38]
MS	org.aavso.tools.vstar.vela.VeLaParser.tokenNames should be package protected
	Bug type MS_PKGPROTECT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser Field org.aavso.tools.vstar.vela.VeLaParser.tokenNames At VeLaParser.java:[line 71]

Multithreaded correctness Warnings

Code	Warning
AT	Shared primitive variable "obsTextProvided" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser In method org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.setObsTextProvided(boolean) Field org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.obsTextProvided At AdditiveLoadFileOrUrlChooser.java:[line 319]
AT	Shared primitive variable "cancelled" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure() Field org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.cancelled At NewStarFromObSourcePluginTask.java:[line 250] Another occurrence at NewStarFromObSourcePluginTask.java:[line 252]
AT	Shared primitive variable "obsCount" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.createObservationArtefacts() Field org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.obsCount At NewStarFromObSourcePluginTask.java:[line 335]
AT	Shared primitive variable "successful" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.ui.task.PeriodAnalysisTask In method org.aavso.tools.vstar.ui.task.PeriodAnalysisTask.doInBackground() Field org.aavso.tools.vstar.ui.task.PeriodAnalysisTask.successful At PeriodAnalysisTask.java:[line 89] Another occurrence at PeriodAnalysisTask.java:[line 91]
AT	This write of the 64-bit primitive variable "maxAmp" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maxAmp At WeightedWaveletZTransform.java:[line 313] Another occurrence at WeightedWaveletZTransform.java:[line 332]
AT	This write of the 64-bit primitive variable "maxPeriod" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maxPeriod At WeightedWaveletZTransform.java:[line 310] Another occurrence at WeightedWaveletZTransform.java:[line 324]
AT	This write of the 64-bit primitive variable "maxWWZ" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maxWWZ At WeightedWaveletZTransform.java:[line 316] Another occurrence at WeightedWaveletZTransform.java:[line 340]
AT	This write of the 64-bit primitive variable "minAmp" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.minAmp At WeightedWaveletZTransform.java:[line 312] Another occurrence at WeightedWaveletZTransform.java:[line 328]
AT	This write of the 64-bit primitive variable "minPeriod" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.minPeriod At WeightedWaveletZTransform.java:[line 309] Another occurrence at WeightedWaveletZTransform.java:[line 320]
AT	This write of the 64-bit primitive variable "minWWZ" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.computeMinAndMaxValues() Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.minWWZ At WeightedWaveletZTransform.java:[line 315] Another occurrence at WeightedWaveletZTransform.java:[line 336]
AT	This write of the 64-bit primitive variable "fhi" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_freq_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.fhi At WeightedWaveletZTransform.java:[line 434]
AT	This write of the 64-bit primitive variable "flo" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_freq_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.flo At WeightedWaveletZTransform.java:[line 433]
AT	This write of the 64-bit primitive variable "fhi" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_period_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.fhi At WeightedWaveletZTransform.java:[line 463]
AT	This write of the 64-bit primitive variable "flo" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_period_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.flo At WeightedWaveletZTransform.java:[line 462]
AT	This write of the 64-bit primitive variable "maxPeriod" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_period_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maxPeriod At WeightedWaveletZTransform.java:[line 460]
AT	This write of the 64-bit primitive variable "minPeriod" may not atomic
	Bug type AT_NONATOMIC_64BIT_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_period_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.minPeriod At WeightedWaveletZTransform.java:[line 459]
AT	Operation on the "ntau" shared variable in "WeightedWaveletZTransform" class is not atomic
	Bug type AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maketau(double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.ntau At WeightedWaveletZTransform.java:[line 389]
AT	Shared primitive variable "numdat" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.dataread(List) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.numdat At WeightedWaveletZTransform.java:[line 358]
AT	Shared primitive variable "nfreq" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_freq_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.nfreq At WeightedWaveletZTransform.java:[line 436]
AT	Shared primitive variable "nfreq" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.make_freqs_from_period_range(double, double, double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.nfreq At WeightedWaveletZTransform.java:[line 465]
AT	Shared primitive variable "ntau" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.maketau(double) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.ntau At WeightedWaveletZTransform.java:[line 385]
AT	Shared primitive variable "threadCount" in one thread may not yield the value of the most recent write from another thread
	Bug type AT_STALE_THREAD_WRITE_OF_PRIMITIVE (click for details) In class org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform In method org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.setThreadCount(int) Field org.aavso.tools.vstar.util.period.wwz.WeightedWaveletZTransform.threadCount At WeightedWaveletZTransform.java:[line 197] Another occurrence at WeightedWaveletZTransform.java:[line 199] Another occurrence at WeightedWaveletZTransform.java:[line 201]
LI	Incorrect lazy initialization of static field org.aavso.tools.vstar.scripting.VStarScriptingAPI.instance in org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance()
	Bug type LI_LAZY_INIT_STATIC (click for details) In class org.aavso.tools.vstar.scripting.VStarScriptingAPI In method org.aavso.tools.vstar.scripting.VStarScriptingAPI.getInstance() On field org.aavso.tools.vstar.scripting.VStarScriptingAPI.instance At VStarScriptingAPI.java:[lines 94-95]
SWL	org.aavso.tools.vstar.scripting.VStarScriptingAPI.pause(long) calls Thread.sleep() with a lock held
	Bug type SWL_SLEEP_WITH_LOCK_HELD (click for details) In class org.aavso.tools.vstar.scripting.VStarScriptingAPI In method org.aavso.tools.vstar.scripting.VStarScriptingAPI.pause(long) At VStarScriptingAPI.java:[line 712]

Performance Warnings

Code	Warning
Dm	new org.aavso.tools.vstar.data.CommentCodes(String) invokes inefficient new String() constructor
	Bug type DM_STRING_VOID_CTOR (click for details) In class org.aavso.tools.vstar.data.CommentCodes In method new org.aavso.tools.vstar.data.CommentCodes(String) At CommentCodes.java:[line 62]
Dm	org.aavso.tools.vstar.input.database.Authenticator.authenticate() invokes inefficient new String(String) constructor
	Bug type DM_STRING_CTOR (click for details) In class org.aavso.tools.vstar.input.database.Authenticator In method org.aavso.tools.vstar.input.database.Authenticator.authenticate() At Authenticator.java:[line 83]
Dm	org.aavso.tools.vstar.ui.mediator.Mediator.createNewStarObservationArtefacts(NewStarType, StarInfo, int, boolean) forces garbage collection; extremely dubious except in benchmarking code
	Bug type DM_GC (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.createNewStarObservationArtefacts(NewStarType, StarInfo, int, boolean) At Mediator.java:[line 1361]
SBSC	org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getInputName() concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getInputName() At AAVSOPhotometryURLObservationSourceBase.java:[line 210]
SBSC	org.aavso.tools.vstar.scripting.VStarScriptingAPI.getSeries() concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.scripting.VStarScriptingAPI In method org.aavso.tools.vstar.scripting.VStarScriptingAPI.getSeries() At VStarScriptingAPI.java:[line 564]
SBSC	org.aavso.tools.vstar.ui.dialog.MultiEntryComponentDialog.okAction() concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.ui.dialog.MultiEntryComponentDialog In method org.aavso.tools.vstar.ui.dialog.MultiEntryComponentDialog.okAction() At MultiEntryComponentDialog.java:[line 216]
SBSC	org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog$3.actionPerformed(ActionEvent) concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog$3 In method org.aavso.tools.vstar.ui.dialog.model.HarmonicInfoDialog$3.actionPerformed(ActionEvent) At HarmonicInfoDialog.java:[line 287]
SBSC	org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure() concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginTask.configure() At NewStarFromObSourcePluginTask.java:[line 113]
SBSC	org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getRelativeSequenceString(double, int, boolean) concatenates strings using + in a loop
	Bug type SBSC_USE_STRINGBUFFER_CONCATENATION (click for details) In class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator In method org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.getRelativeSequenceString(double, int, boolean) At RelativeAmplitudeAndPhaseCreator.java:[line 134]
SIC	Should org.aavso.tools.vstar.ui.dialog.DateToJdDialog$DoubleFieldSeconds be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.DateToJdDialog$DoubleFieldSeconds At DateToJdDialog.java:[lines 294-306]
SIC	Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ChartFontLabel be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ChartFontLabel At ChartPropertiesSelectionPane.java:[lines 172-194]
SIC	Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ColorRectComponent be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$ColorRectComponent At ChartPropertiesSelectionPane.java:[lines 131-167]
SIC	Should org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog At ChartPropertiesSelectionPane.java:[lines 65-119]
SIC	Should org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane$DotComponent be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.SeriesSizeSelectionPane$DotComponent At SeriesSizeSelectionPane.java:[lines 70-90]
SIC	Should org.aavso.tools.vstar.util.period.dcdft.TSDcDft$ResolutionResult be a _static_ inner class?
	Bug type SIC_INNER_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft$ResolutionResult At TSDcDft.java:[lines 1019-1023]
SS	Unread field: org.aavso.tools.vstar.data.validation.JulianDayValidator.pattern; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.data.validation.JulianDayValidator Field org.aavso.tools.vstar.data.validation.JulianDayValidator.pattern At JulianDayValidator.java:[line 34]
SS	Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_INDEX; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator Field org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_INDEX At MagnitudeFieldValidator.java:[line 35]
SS	Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_MODIFIER_INDEX; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator Field org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.MAG_MODIFIER_INDEX At MagnitudeFieldValidator.java:[line 34]
SS	Unread field: org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.UNCERTAINTY_INDEX; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator Field org.aavso.tools.vstar.data.validation.MagnitudeFieldValidator.UNCERTAINTY_INDEX At MagnitudeFieldValidator.java:[line 36]
SS	Unread field: org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE At PluginManagementDialog.java:[line 72]
SS	Unread field: org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE_MOD; should this field be static?
	Bug type SS_SHOULD_BE_STATIC (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog Field org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManagementDialog.DIALOG_TITLE_MOD At PluginManagementDialog.java:[line 73]
WMI	org.aavso.tools.vstar.data.SeriesType.updateSeriesColorMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.data.SeriesType In method org.aavso.tools.vstar.data.SeriesType.updateSeriesColorMap(Map) At SeriesType.java:[line 594]
WMI	org.aavso.tools.vstar.data.SeriesType.updateSeriesSizeMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.data.SeriesType In method org.aavso.tools.vstar.data.SeriesType.updateSeriesSizeMap(Map) At SeriesType.java:[line 621]
WMI	org.aavso.tools.vstar.data.ValidObservation.toString() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.toString() Field org.aavso.tools.vstar.data.ValidObservation.details At ValidObservation.java:[line 1139]
WMI	org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getURLs() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.getURLs() Field org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase.seriesNameToTypeMap At AAVSOPhotometryURLObservationSourceBase.java:[line 187]
WMI	org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.dialog.InfoDialog In method org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List) At InfoDialog.java:[line 131]
WMI	new org.aavso.tools.vstar.ui.dialog.prefs.LocaleSelectionPane() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.LocaleSelectionPane In method new org.aavso.tools.vstar.ui.dialog.prefs.LocaleSelectionPane() At LocaleSelectionPane.java:[line 66]
WMI	org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.seriesVisibilityChange(Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane In method org.aavso.tools.vstar.ui.dialog.series.SeriesVisibilityPane.seriesVisibilityChange(Map) At SeriesVisibilityPane.java:[line 429]
WMI	org.aavso.tools.vstar.ui.mediator.Mediator.createPhasePlotArtefacts(double, double, Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.createPhasePlotArtefacts(double, double, Map) Field org.aavso.tools.vstar.ui.mediator.Mediator.validObservationCategoryMap At Mediator.java:[line 1517]
WMI	org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.toString() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage In method org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.toString() Field org.aavso.tools.vstar.ui.mediator.message.PhaseChangeMessage.seriesVisibilityMap At PhaseChangeMessage.java:[line 84]
WMI	org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.determineMeanSeriesSource() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.determineMeanSeriesSource() Field org.aavso.tools.vstar.ui.model.plot.ObservationAndMeanPlotModel.srcTypeToSeriesNumMap At ObservationAndMeanPlotModel.java:[line 403] Another occurrence at ObservationAndMeanPlotModel.java:[line 412] Another occurrence at ObservationAndMeanPlotModel.java:[line 423] Another occurrence at ObservationAndMeanPlotModel.java:[line 441] Another occurrence at ObservationAndMeanPlotModel.java:[line 471]
WMI	new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator) At ObservationPlotModel.java:[line 170]
WMI	new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel(Map, ICoordSource, Comparator, Map) At ObservationPlotModel.java:[line 237]
WMI	org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getVisibleSeries() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel In method org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.getVisibleSeries() Field org.aavso.tools.vstar.ui.model.plot.ObservationPlotModel.seriesVisibilityMap At ObservationPlotModel.java:[line 467]
WMI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.seriesVisibilityChange(Map) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.seriesVisibilityChange(Map) At AbstractObservationPlotPane.java:[line 323]
WMI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale() At AbstractObservationPlotPane.java:[line 664]
WMI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesColors() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesColors() At AbstractObservationPlotPane.java:[line 349]
WMI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesSizes() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesSizes() At AbstractObservationPlotPane.java:[line 361]
WMI	org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesVisibility() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setSeriesVisibility() At AbstractObservationPlotPane.java:[line 338]
WMI	org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() Field org.aavso.tools.vstar.ui.resources.StarGroups.starGroupMap At StarGroups.java:[line 254]
WMI	org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.ui.resources.StarGroups In method org.aavso.tools.vstar.ui.resources.StarGroups.createStarGroupPrefsValue() At StarGroups.java:[line 267]
WMI	org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.hasHarmonics() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator In method org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.hasHarmonics() Field org.aavso.tools.vstar.util.model.RelativeAmplitudeAndPhaseCreator.harmonicMap At RelativeAmplitudeAndPhaseCreator.java:[line 84]
WMI	org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.toString() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint In method org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.toString() Field org.aavso.tools.vstar.util.period.dcdft.PeriodAnalysisDataPoint.coords At PeriodAnalysisDataPoint.java:[line 148]
WMI	org.aavso.tools.vstar.vela.VeLaEnvironment.toString() makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.vela.VeLaEnvironment In method org.aavso.tools.vstar.vela.VeLaEnvironment.toString() Field org.aavso.tools.vstar.vela.VeLaEnvironment.cache At VeLaEnvironment.java:[line 143]
WMI	org.aavso.tools.vstar.vela.VeLaInterpreter$3.apply(List) makes inefficient use of keySet iterator instead of entrySet iterator
	Bug type WMI_WRONG_MAP_ITERATOR (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter$3 In method org.aavso.tools.vstar.vela.VeLaInterpreter$3.apply(List) At VeLaInterpreter.java:[line 1539]

Dodgy code Warnings

Code	Warning
DLS	Dead store to starName in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getURLs()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getURLs() Local variable named starName At AIDWebServiceObservationSourcePluginBase.java:[line 259] Another occurrence at AIDWebServiceObservationSourcePluginBase.java:[line 270]
DLS	Dead store to lastGroup in org.aavso.tools.vstar.ui.MenuBar.createAnalysisMenu()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.ui.MenuBar In method org.aavso.tools.vstar.ui.MenuBar.createAnalysisMenu() Local variable named lastGroup At MenuBar.java:[line 549]
DLS	Dead store to statsTextArea in org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List)
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.ui.dialog.InfoDialog In method org.aavso.tools.vstar.ui.dialog.InfoDialog.createInfoPanel(List) Local variable named statsTextArea At InfoDialog.java:[line 143]
DLS	Dead store to jda in org.aavso.tools.vstar.util.TSBase.load_raw()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.TSBase In method org.aavso.tools.vstar.util.TSBase.load_raw() Local variable named jda At TSBase.java:[line 140]
DLS	Dead store to jdb in org.aavso.tools.vstar.util.TSBase.load_raw()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.TSBase In method org.aavso.tools.vstar.util.TSBase.load_raw() Local variable named jdb At TSBase.java:[line 141]
DLS	Dead store to damplit in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.dcdftCommon()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.dcdftCommon() Local variable named damplit At TSDcDft.java:[line 364]
DLS	Dead store to hiper in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.frequency_range()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.frequency_range() Local variable named hiper At TSDcDft.java:[line 455]
DLS	Dead store to nnn in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel)
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.multiPeriodicFit(List, PeriodAnalysisDerivedMultiPeriodicModel) Local variable named nnn At TSDcDft.java:[line 972]
DLS	Dead store to xlofre in org.aavso.tools.vstar.util.period.dcdft.TSDcDft.period_range()
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.util.period.dcdft.TSDcDft In method org.aavso.tools.vstar.util.period.dcdft.TSDcDft.period_range() Local variable named xlofre At TSDcDft.java:[line 512]
DLS	Dead store to parameterNames in new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional)
	Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.aavso.tools.vstar.vela.JavaMethodExecutor In method new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional) Local variable named parameterNames At JavaMethodExecutor.java:[line 58]
FE	Test for floating point equality in org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale()
	Bug type FE_FLOATING_POINT_EQUALITY (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane In method org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.setMagScale() At AbstractObservationPlotPane.java:[line 697]
FE	Test for floating point equality in org.aavso.tools.vstar.util.model.Harmonic.isHarmonic(Harmonic)
	Bug type FE_FLOATING_POINT_EQUALITY (click for details) In class org.aavso.tools.vstar.util.model.Harmonic In method org.aavso.tools.vstar.util.model.Harmonic.isHarmonic(Harmonic) At Harmonic.java:[line 118]
IA	Potentially ambiguous invocation of either an outer or inherited method org.aavso.tools.vstar.ui.dialog.AbstractOkCancelDialog.createButtonPane() in new org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog(ChartPropertiesSelectionPane, Font)
	Bug type IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD (click for details) In class org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog In method new org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane$FontDialog(ChartPropertiesSelectionPane, Font) Inherited method org.aavso.tools.vstar.ui.dialog.AbstractOkCancelDialog.createButtonPane() Did you intend to invoke org.aavso.tools.vstar.ui.dialog.prefs.ChartPropertiesSelectionPane.createButtonPane() At ChartPropertiesSelectionPane.java:[line 84]
ICAST	Integral division result cast to double or float in new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction)
	Bug type ICAST_IDIV_CAST_TO_DOUBLE (click for details) In class org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel In method new org.aavso.tools.vstar.ui.model.plot.ContinuousModelPlotModel(ContinuousModelFunction) At ContinuousModelPlotModel.java:[line 53]
ICAST	Integral division result cast to double or float in org.aavso.tools.vstar.ui.pane.plot.VStarPlotDataRenderer.setSeriesSize(int, int)
	Bug type ICAST_IDIV_CAST_TO_DOUBLE (click for details) In class org.aavso.tools.vstar.ui.pane.plot.VStarPlotDataRenderer In method org.aavso.tools.vstar.ui.pane.plot.VStarPlotDataRenderer.setSeriesSize(int, int) At VStarPlotDataRenderer.java:[line 45]
NP	Load of known null value in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String)
	Bug type NP_LOAD_OF_KNOWN_NULL_VALUE (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceObservationSourcePluginBase.getMType(String) Value loaded from mtypeStr At AIDWebServiceObservationSourcePluginBase.java:[line 401]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() Value loaded from jarFiles Dereferenced at PluginManager.java:[line 911] Known null at PluginManager.java:[line 910]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.deleteAllPlugins() Value loaded from libJarFiles Dereferenced at PluginManager.java:[line 926] Known null at PluginManager.java:[line 925]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() Value loaded from ? Dereferenced at PluginManager.java:[line 634] Known null at PluginManager.java:[line 634]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager In method org.aavso.tools.vstar.ui.dialog.plugin.manager.PluginManager.retrieveLocalPluginInfo() Value loaded from ? Dereferenced at PluginManager.java:[line 649] Known null at PluginManager.java:[line 649]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.resources.PluginLoader In method org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() Value loaded from ? Dereferenced at PluginLoader.java:[line 236] Known null at PluginLoader.java:[line 236]
NP	Possible null pointer dereference in org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.ui.resources.PluginLoader In method org.aavso.tools.vstar.ui.resources.PluginLoader.loadPlugins() Value loaded from ? Dereferenced at PluginLoader.java:[line 259] Known null at PluginLoader.java:[line 259]
NP	Possible null pointer dereference in org.aavso.tools.vstar.vela.VeLaInterpreter.loadUserCode() due to return value of called method
	Bug type NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter In method org.aavso.tools.vstar.vela.VeLaInterpreter.loadUserCode() Value loaded from ? Dereferenced at VeLaInterpreter.java:[line 1267] Known null at VeLaInterpreter.java:[line 1267]
RCN	Redundant nullcheck of id, which is known to be non-null in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceCSVObservationSourcePlugin$VSXCSVObservationRetriever.retrieveNextObservation(CsvReader)
	Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceCSVObservationSourcePlugin$VSXCSVObservationRetriever In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceCSVObservationSourcePlugin$VSXCSVObservationRetriever.retrieveNextObservation(CsvReader) Value loaded from id Redundant null check at AIDWebServiceCSVObservationSourcePlugin.java:[line 396]
RCN	Redundant nullcheck of id, which is known to be non-null in org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceXMLAttributeObservationSourcePlugin$VSXAIDAttributeObservationRetriever.retrieveObservation(INodeSequence)
	Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceXMLAttributeObservationSourcePlugin$VSXAIDAttributeObservationRetriever In method org.aavso.tools.vstar.plugin.ob.src.impl.AIDWebServiceXMLAttributeObservationSourcePlugin$VSXAIDAttributeObservationRetriever.retrieveObservation(INodeSequence) Value loaded from id Redundant null check at AIDWebServiceXMLAttributeObservationSourcePlugin.java:[line 340]
RCN	Redundant nullcheck of org.aavso.tools.vstar.ui.ToolBar.newStarFromDatabaseIcon, which is known to be non-null in org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons()
	Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) In class org.aavso.tools.vstar.ui.ToolBar In method org.aavso.tools.vstar.ui.ToolBar.retrieveToolBarIcons() Value loaded from field org.aavso.tools.vstar.ui.ToolBar.newStarFromDatabaseIcon Redundant null check at ToolBar.java:[line 216]
REC	Exception is caught when Exception is not thrown in org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>()
	Bug type REC_CATCH_EXCEPTION (click for details) In class org.aavso.tools.vstar.ui.VStar In method org.aavso.tools.vstar.ui.VStar.<static initializer for VStar>() At VStar.java:[line 62]
REC	Exception is caught when Exception is not thrown in org.aavso.tools.vstar.vela.Operand.object2Operand(Type, Object)
	Bug type REC_CATCH_EXCEPTION (click for details) In class org.aavso.tools.vstar.vela.Operand In method org.aavso.tools.vstar.vela.Operand.object2Operand(Type, Object) At Operand.java:[line 369]
RV	Return value of org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() ignored, but method has no side effect
	Bug type RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedFileTask.createObservationArtefacts() Called method org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() At NewStarFromObSourcePluginWithSuppliedFileTask.java:[line 124]
RV	Return value of org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() ignored, but method has no side effect
	Bug type RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT (click for details) In class org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask In method org.aavso.tools.vstar.ui.task.NewStarFromObSourcePluginWithSuppliedURLTask.createObservationArtefacts() Called method org.aavso.tools.vstar.input.AbstractObservationRetriever.getNumberOfRecords() At NewStarFromObSourcePluginWithSuppliedURLTask.java:[line 125]
SA	Double assignment of urlStr in org.aavso.tools.vstar.util.help.Help.openPluginHelp(String)
	Bug type SA_LOCAL_DOUBLE_ASSIGNMENT (click for details) In class org.aavso.tools.vstar.util.help.Help In method org.aavso.tools.vstar.util.help.Help.openPluginHelp(String) Local variable named urlStr At Help.java:[line 82]
SF	Switch statement found in org.aavso.tools.vstar.data.filter.BooleanFieldMatcher.matches(ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.data.filter.BooleanFieldMatcher In method org.aavso.tools.vstar.data.filter.BooleanFieldMatcher.matches(ValidObservation) At BooleanFieldMatcher.java:[lines 45-50]
SF	Switch statement found in org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.matches(ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.data.filter.DoubleFieldMatcher In method org.aavso.tools.vstar.data.filter.DoubleFieldMatcher.matches(ValidObservation) At DoubleFieldMatcher.java:[lines 53-71]
SF	Switch statement found in org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher.matches(ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher In method org.aavso.tools.vstar.data.filter.SeriesTypeFieldMatcher.matches(ValidObservation) At SeriesTypeFieldMatcher.java:[lines 87-92]
SF	Switch statement found in org.aavso.tools.vstar.data.filter.StringFieldMatcher.matches(ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.data.filter.StringFieldMatcher In method org.aavso.tools.vstar.data.filter.StringFieldMatcher.matches(ValidObservation) At StringFieldMatcher.java:[lines 56-64]
SF	Switch statement found in org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLSearchParameterDialog$2.actionPerformed(ActionEvent) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLSearchParameterDialog$2 In method org.aavso.tools.vstar.plugin.ob.src.impl.AAVSOPhotometryURLObservationSourceBase$AAVSOPhotometryURLSearchParameterDialog$2.actionPerformed(ActionEvent) At AAVSOPhotometryURLObservationSourceBase.java:[lines 516-527]
SF	Switch statement found in org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.createPluginsList() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser In method org.aavso.tools.vstar.ui.dialog.AdditiveLoadFileOrUrlChooser.createPluginsList() At AdditiveLoadFileOrUrlChooser.java:[lines 208-221]
SF	Switch statement found in org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String) where one case falls through to the next case
	Bug type SF_SWITCH_FALLTHROUGH (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.saveSyntheticObsListToFile(Component, ObservationSinkPluginBase, ViewModeType, File, String) At Mediator.java:[lines 2058-2066]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnClass(int) At AAVSOFormatRawDataColumnInfoSource.java:[lines 247-304]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnTitle(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnTitle(int) At AAVSOFormatRawDataColumnInfoSource.java:[lines 153-236]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.AAVSOFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) At AAVSOFormatRawDataColumnInfoSource.java:[lines 315-400]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnClass(int) At InvalidObservationTableModel.java:[lines 116-125]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnName(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getColumnName(int) At InvalidObservationTableModel.java:[lines 70-78]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getValueAt(int, int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel In method org.aavso.tools.vstar.ui.model.list.InvalidObservationTableModel.getValueAt(int, int) At InvalidObservationTableModel.java:[lines 93-104]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnClass(int) At PhasePlotMeanObservationTableModel.java:[lines 124-132]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnName(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getColumnName(int) At PhasePlotMeanObservationTableModel.java:[lines 74-82]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getValueAt(int, int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotMeanObservationTableModel.getValueAt(int, int) At PhasePlotMeanObservationTableModel.java:[lines 99-110]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnClass(int) At PhasePlotModelObservationTableModel.java:[lines 62-67]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnName(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getColumnName(int) At PhasePlotModelObservationTableModel.java:[lines 93-98]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getValueAt(int, int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.PhasePlotModelObservationTableModel.getValueAt(int, int) At PhasePlotModelObservationTableModel.java:[lines 126-131]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnClass(int) At RawDataMeanObservationTableModel.java:[lines 131-142]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnName(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getColumnName(int) At RawDataMeanObservationTableModel.java:[lines 74-85]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getValueAt(int, int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataMeanObservationTableModel.getValueAt(int, int) At RawDataMeanObservationTableModel.java:[lines 103-118]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnClass(int) At RawDataModelObservationTableModel.java:[lines 63-71]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnName(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getColumnName(int) At RawDataModelObservationTableModel.java:[lines 97-105]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getValueAt(int, int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel In method org.aavso.tools.vstar.ui.model.list.RawDataModelObservationTableModel.getValueAt(int, int) At RawDataModelObservationTableModel.java:[lines 133-142]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnClass(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnClass(int) At SimpleFormatRawDataColumnInfoSource.java:[lines 113-128]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnTitle(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnTitle(int) At SimpleFormatRawDataColumnInfoSource.java:[lines 82-102]
SF	Switch statement found in org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource In method org.aavso.tools.vstar.ui.model.list.SimpleFormatRawDataColumnInfoSource.getTableColumnValue(int, ValidObservation) At SimpleFormatRawDataColumnInfoSource.java:[lines 139-162]
SF	Switch statement found in org.aavso.tools.vstar.ui.vela.VeLaDialog$2.keyTyped(KeyEvent) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog$2 In method org.aavso.tools.vstar.ui.vela.VeLaDialog$2.keyTyped(KeyEvent) At VeLaDialog.java:[lines 296-324]
SF	Switch statement found in org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.getTypeFromId(int) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType In method org.aavso.tools.vstar.util.period.wwz.WWZCoordinateType.getTypeFromId(int) At WWZCoordinateType.java:[lines 52-72]
SF	Switch statement found in org.aavso.tools.vstar.vela.Type.name2Vela(String) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.Type In method org.aavso.tools.vstar.vela.Type.name2Vela(String) At Type.java:[lines 115-146]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaInterpreter$10.apply(List) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaInterpreter$10 In method org.aavso.tools.vstar.vela.VeLaInterpreter$10.apply(List) At VeLaInterpreter.java:[lines 1677-1694]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.anonFundef() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.anonFundef() At VeLaParser.java:[lines 2034-2038]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.funcall() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.funcall() At VeLaParser.java:[lines 1528-1548]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.ifExpression() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.ifExpression() At VeLaParser.java:[lines 648-654]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.list() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.list() At VeLaParser.java:[lines 1900-1904]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.namedFundef() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.namedFundef() At VeLaParser.java:[lines 334-338]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaParser.sequence() where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaParser In method org.aavso.tools.vstar.vela.VeLaParser.sequence() At VeLaParser.java:[lines 170-192]
SF	Switch statement found in org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment.operand(Type, String, Object) where default case is missing
	Bug type SF_SWITCH_NO_DEFAULT (click for details) In class org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment In method org.aavso.tools.vstar.vela.VeLaValidObservationEnvironment.operand(Type, String, Object) At VeLaValidObservationEnvironment.java:[lines 168-182]
ST	Write to static field org.aavso.tools.vstar.data.ValidObservation.detailIndex from instance method org.aavso.tools.vstar.data.ValidObservation.addDetail(String, Property, String)
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.data.ValidObservation In method org.aavso.tools.vstar.data.ValidObservation.addDetail(String, Property, String) Field org.aavso.tools.vstar.data.ValidObservation.detailIndex At ValidObservation.java:[line 398]
ST	Write to static field org.aavso.tools.vstar.ui.mediator.DocumentManager.filterNum from instance method org.aavso.tools.vstar.ui.mediator.DocumentManager.getNextUntitledFilterName()
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.ui.mediator.DocumentManager In method org.aavso.tools.vstar.ui.mediator.DocumentManager.getNextUntitledFilterName() Field org.aavso.tools.vstar.ui.mediator.DocumentManager.filterNum At DocumentManager.java:[line 321]
ST	Write to static field org.aavso.tools.vstar.ui.mediator.Mediator.ui from instance method org.aavso.tools.vstar.ui.mediator.Mediator.setUI(IMainUI)
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method org.aavso.tools.vstar.ui.mediator.Mediator.setUI(IMainUI) Field org.aavso.tools.vstar.ui.mediator.Mediator.ui At Mediator.java:[line 376]
ST	Write to static field org.aavso.tools.vstar.ui.mediator.Mediator.ui from instance method new org.aavso.tools.vstar.ui.mediator.Mediator()
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.ui.mediator.Mediator In method new org.aavso.tools.vstar.ui.mediator.Mediator() Field org.aavso.tools.vstar.ui.mediator.Mediator.ui At Mediator.java:[line 295]
ST	Write to static field org.aavso.tools.vstar.ui.vela.VeLaDialog.code from instance method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String)
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog In method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String) Field org.aavso.tools.vstar.ui.vela.VeLaDialog.code At VeLaDialog.java:[line 101]
ST	Write to static field org.aavso.tools.vstar.ui.vela.VeLaDialog.code from instance method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String, JComponent, Consumer)
	Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details) In class org.aavso.tools.vstar.ui.vela.VeLaDialog In method new org.aavso.tools.vstar.ui.vela.VeLaDialog(String, String, JComponent, Consumer) Field org.aavso.tools.vstar.ui.vela.VeLaDialog.code At VeLaDialog.java:[line 140]
UC	Method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.datasetChanged(DatasetChangeEvent) seems to be useless
	Bug type UC_USELESS_VOID_METHOD (click for details) In class org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane In method org.aavso.tools.vstar.ui.dialog.period.PeriodAnalysis2DChartPane.datasetChanged(DatasetChangeEvent) At PeriodAnalysis2DChartPane.java:[line 269]
UC	Useless condition: it's known that this.interrupted == false at this point
	Bug type UC_USELESS_CONDITION (click for details) In class org.aavso.tools.vstar.util.TSBase In method org.aavso.tools.vstar.util.TSBase.project() Value this.interrupted == false Unreachable code at TSBase.java:[line 513] At TSBase.java:[line 512]
UC	Useless object stored in variable dzeta of method org.aavso.tools.vstar.util.model.TSPolynomialFitter.polyfit()
	Bug type UC_USELESS_OBJECT (click for details) In class org.aavso.tools.vstar.util.model.TSPolynomialFitter In method org.aavso.tools.vstar.util.model.TSPolynomialFitter.polyfit() Value dzeta Type double[] At TSPolynomialFitter.java:[line 267]
UC	Useless object stored in variable extendedParams of method new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional)
	Bug type UC_USELESS_OBJECT (click for details) In class org.aavso.tools.vstar.vela.JavaMethodExecutor In method new org.aavso.tools.vstar.vela.JavaMethodExecutor(Object, Method, Optional, List, List, Optional, Optional) Value extendedParams Type java.util.ArrayList At JavaMethodExecutor.java:[line 55]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.dsig
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.dsig At TSBase.java:[line 249]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.dtsig
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.dtsig At TSBase.java:[line 270]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.magspan
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.magspan At TSBase.java:[line 182]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.ndigt
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.ndigt At TSBase.java:[line 196]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.obias
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.obias At TSBase.java:[line 87]
UrF	Unread public/protected field: org.aavso.tools.vstar.util.TSBase.tmark
	Bug type URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.TSBase Field org.aavso.tools.vstar.util.TSBase.tmark At TSBase.java:[line 211]
UwF	Unwritten public or protected field: org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.seriesVisibilityPane
	Bug type UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog Field org.aavso.tools.vstar.ui.dialog.series.AbstractSeriesVisibilityDialog.seriesVisibilityPane At AbstractSeriesVisibilityDialog.java:[line 91]
UwF	Unwritten public or protected field: org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.chartControlPanel
	Bug type UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.chartControlPanel At AbstractObservationPlotPane.java:[line 239]
UwF	Unwritten public or protected field: org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsInfo
	Bug type UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane Field org.aavso.tools.vstar.ui.pane.plot.AbstractObservationPlotPane.obsInfo At AbstractObservationPlotPane.java:[line 246]
UwF	Unwritten public or protected field: org.aavso.tools.vstar.util.notification.NotifyingList.notifier
	Bug type UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (click for details) In class org.aavso.tools.vstar.util.notification.NotifyingList Field org.aavso.tools.vstar.util.notification.NotifyingList.notifier At NotifyingArrayList.java:[line 81]

Details

AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE: Operation on shared variable is not atomic

This write of a variable shared between functions depends on the current value of the variable (either because it's a compound operation - e.g. +=, ++ - or it simply depends on the current value), as such it consists of more than one discrete operation. These operations are not atomic in themselves and need further synchronization. See SEI CERT rule VNA02-J. Simply declaring a variable volatile fails to guarantee the atomicity of compound operations on the variable, but synchronizing the writes on top of declaring the variable volatile for read operations is sufficient.

To solve this issue, synchronize compound operations and other write operations depending on the previous value, use read-write locks, or declare the shared variable with an atomic type.

AT_NONATOMIC_64BIT_PRIMITIVE: This write of this 64-bit primitive variable may not atomic

The long and the double are 64-bit primitive types, and depending on the Java Virtual Machine implementation assigning a value to them can be treated as two separate 32-bit writes, and as such it's not atomic. See JSL 17.7. Non-Atomic Treatment of double and long. See SEI CERT rule VNA05-J. Ensure atomicity when reading and writing 64-bit values for more info. This bug can be ignored in platforms which guarantee that 64-bit long and double type read and write operations are atomic.

To fix it, declare the variable volatile, change the type of the field to the corresponding atomic type from java.lang.concurrent.atomic or correctly synchronize the code. Declaring the variable volatile may not be enough in some cases: e.g. when the variable is assigned a value which depends on the current value or on the result of nonatomic compound operations.

AT_STALE_THREAD_WRITE_OF_PRIMITIVE: This write of this shared primitive variable may not be visible to other threads

SEI CERT rule VNA00-J describes that reading a shared primitive variable in one thread may not yield the value of the most recent write to the variable from another thread. Consequently, the thread may observe a stale value of the shared variable.

CT_CONSTRUCTOR_THROW: Be wary of letting constructors throw exceptions.

Classes that throw exceptions in their constructors are vulnerable to Finalizer attacks

A finalizer attack can be prevented, by declaring the class final, using an empty finalizer declared as final, or by a clever use of a private constructor.

See SEI CERT Rule OBJ-11 for more information.

CO_COMPARETO_INCORRECT_FLOATING: compareTo()/compare() incorrectly handles float or double value

This method compares double or float values using pattern like this: val1 > val2 ? 1 : val1 < val2 ? -1 : 0. This pattern works incorrectly for -0.0 and NaN values which may result in incorrect sorting result or broken collection (if compared values are used as keys). Consider using Double.compare or Float.compare static methods which handle all the special cases correctly.

DE_MIGHT_IGNORE: Method might ignore exception

This method might ignore an exception. In general, exceptions should be handled or reported in some way, or they should be thrown out of the method.

DLS_DEAD_LOCAL_STORE: Dead store to local variable

This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.

Note that Sun's javac compiler often generates dead stores for final local variables. Because SpotBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.

DM_GC: Explicit garbage collection; extremely dubious except in benchmarking code

Code explicitly invokes garbage collection. Except for specific use in benchmarking, this is very dubious.

In the past, situations where people have explicitly invoked the garbage collector in routines such as close or finalize methods has led to huge performance black holes. Garbage collection can be expensive. Any situation that forces hundreds or thousands of garbage collections will bring the machine to a crawl.

DM_EXIT: Method invokes System.exit(...)

Invoking System.exit shuts down the entire Java virtual machine. This should only been done when it is appropriate. Such calls make it hard or impossible for your code to be invoked by other code. Consider throwing a RuntimeException instead.

DM_STRING_VOID_CTOR: Method invokes inefficient new String() constructor

Creating a new java.lang.String object using the no-argument constructor wastes memory because the object so created will be functionally indistinguishable from the empty string constant "". Java guarantees that identical string constants will be represented by the same String object. Therefore, you should just use the empty string constant directly.

DM_STRING_CTOR: Method invokes inefficient new String(String) constructor

Using the java.lang.String(String) constructor wastes memory because the object so constructed will be functionally indistinguishable from the String passed as a parameter. Just use the argument String directly.

DM_DEFAULT_ENCODING: Reliance on default encoding

Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behavior to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

EC_UNRELATED_TYPES: Call to equals() comparing different types

This method calls equals(Object) on two references of different class types and analysis suggests they will be to objects of different classes at runtime. Further, examination of the equals methods that would be invoked suggest that either this call will always return false, or else the equals method is not symmetric (which is a property required by the contract for equals in class Object).

EI_EXPOSE_REP: May expose internal representation by returning reference to mutable object

Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object

This code stores a reference to an externally mutable object into the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.

ES_COMPARING_STRINGS_WITH_EQ: Comparison of String objects using == or !=

This code compares java.lang.String objects for reference equality using the == or != operators. Unless both strings are either constants in a source file, or have been interned using the String.intern() method, the same string value may be represented by two different String objects. Consider using the equals(Object) method instead.

ES_COMPARING_PARAMETER_STRING_WITH_EQ: Comparison of String parameter using == or !=

This code compares a java.lang.String parameter for reference equality using the == or != operators. Requiring callers to pass only String constants or interned strings to a method is unnecessarily fragile, and rarely leads to measurable performance gains. Consider using the equals(Object) method instead.

EQ_COMPARETO_USE_OBJECT_EQUALS: Class defines compareTo(...) and uses Object.equals()

This class defines a compareTo(...) method but inherits its equals() method from java.lang.Object. Generally, the value of compareTo should return zero if and only if equals returns true. If this is violated, weird and unpredictable failures will occur in classes such as PriorityQueue. In Java 5 the PriorityQueue.remove method uses the compareTo method, while in Java 6 it uses the equals method.

From the JavaDoc for the compareTo method in the Comparable interface:

It is strongly recommended, but not strictly required that (x.compareTo(y)==0) == (x.equals(y)). Generally speaking, any class that implements the Comparable interface and violates this condition should clearly indicate this fact. The recommended language is "Note: this class has a natural ordering that is inconsistent with equals."

FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER: Doomed test for equality to NaN

This code checks to see if a floating point value is equal to the special Not A Number value (e.g., if (x == Double.NaN)). However, because of the special semantics of NaN, no value is equal to Nan, including NaN. Thus, x == Double.NaN always evaluates to false. To check to see if a value contained in x is the special Not A Number value, use Double.isNaN(x) (or Float.isNaN(x) if x is floating point precision).

FE_FLOATING_POINT_EQUALITY: Test for floating point equality

This operation compares two floating point values for equality. Because floating point calculations may involve rounding, calculated float and double values may not be accurate. For values that must be precise, such as monetary values, consider using a fixed-precision type such as BigDecimal. For values that need not be precise, consider comparing for equality within some range, for example: if ( Math.abs(x - y) < .0000001 ). See the Java Language Specification, section 4.2.4.

FL_FLOATS_AS_LOOP_COUNTERS: Do not use floating-point variables as loop counters

Using floating-point variables should not be used as loop counters, as they are not precise, which may result in incorrect loops. A loop counter is a variable that is changed with each iteration and controls when the loop should terminate. It is decreased or increased by a fixed amount each iteration.

See rule NUM09-J.

VA_FORMAT_STRING_USES_NEWLINE: Format string should use %n rather than \n

This format string includes a newline character (\n). In format strings, it is generally preferable to use %n, which will produce the platform-specific line separator. When using text blocks introduced in Java 15, use the \ escape sequence: String value = """ first line%n\ second line%n\ """;

HE_EQUALS_USE_HASHCODE: Class defines equals() and uses Object.hashCode()

This class overrides equals(Object), but does not override hashCode(), and inherits the implementation of hashCode() from java.lang.Object (which returns the identity hash code, an arbitrary value assigned to the object by the VM). Therefore, the class is very likely to violate the invariant that equal objects must have equal hashcodes.

If you don't think instances of this class will ever be inserted into a HashMap/HashTable, the recommended hashCode implementation to use is:

public int hashCode() {
    assert false : "hashCode not designed";
    return 42; // any arbitrary constant will do
}

IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD: Potentially ambiguous invocation of either an inherited or outer method

An inner class is invoking a method that could be resolved to either an inherited method or a method defined in an outer class. For example, you invoke foo(17), which is defined in both a superclass and in an outer method. By the Java semantics, it will be resolved to invoke the inherited method, but this may not be what you intend.

If you really intend to invoke the inherited method, invoke it by invoking the method on super (e.g., invoke super.foo(17)), and thus it will be clear to other readers of your code and to SpotBugs that you want to invoke the inherited method, not the method in the outer class.

If you call this.foo(17), then the inherited method will be invoked. However, since SpotBugs only looks at classfiles, it cannot tell the difference between an invocation of this.foo(17) and foo(17), it will still complain about a potential ambiguous invocation.

ICAST_IDIV_CAST_TO_DOUBLE: Integral division result cast to double or float

This code casts the result of an integral division (e.g., int or long division) operation to double or float. Doing division on integers truncates the result to the integer value closest to zero. The fact that the result was cast to double suggests that this precision should have been retained. What was probably meant was to cast one or both of the operands to double before performing the division. Here is an example:

int x = 2;
int y = 5;
// Wrong: yields result 0.0
double value1 = x / y;

// Right: yields result 0.4
double value2 = x / (double) y;

IL_INFINITE_LOOP: An apparent infinite loop

This loop doesn't seem to have a way to terminate (other than by perhaps throwing an exception).

LI_LAZY_INIT_STATIC: Incorrect lazy initialization of static field

This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem. For more information, see the Java Memory Model web site.

ME_MUTABLE_ENUM_FIELD: Enum field is public and mutable

A mutable public field is defined inside a public enum, thus can be changed by malicious code or by accident from another package. Though mutable enum fields may be used for lazy initialization, it's a bad practice to expose them to the outer world. Consider declaring this field final and/or package-private.

MF_CLASS_MASKS_FIELD: Class defines field that masks a superclass field

This class defines a field with the same name as a visible instance field in a superclass. This is confusing, and may indicate an error if methods update or access one of the fields when they wanted the other.

MS_MUTABLE_COLLECTION: Field is a mutable collection

A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. Consider wrapping this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.

MS_MUTABLE_COLLECTION_PKGPROTECT: Field is a mutable collection which should be package protected

A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.

MS_SHOULD_BE_FINAL: Field isn't final but should be

This public static or protected static field is not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.

MS_FINAL_PKGPROTECT: Field should be both final and package protected

A mutable static field could be changed by malicious code or by accident from another package. The field could be made package protected and/or made final to avoid this vulnerability.

MS_PKGPROTECT: Field should be package protected

A mutable static field could be changed by malicious code or by accident. The field could be made package protected to avoid this vulnerability.

MS_EXPOSE_REP: Public static method may expose internal representation by returning a mutable object or array

A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

NP_LOAD_OF_KNOWN_NULL_VALUE: Load of known null value

The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).

NP_BOOLEAN_RETURN_NULL: Method with Boolean return type returns explicit null

A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen. This method can be invoked as though it returned a value of type boolean, and the compiler will insert automatic unboxing of the Boolean value. If a null value is returned, this will result in a NullPointerException.

NP_NULL_ON_SOME_PATH: Possible null pointer dereference

There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception cannot ever be executed; deciding that is beyond the ability of SpotBugs.

NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to return value of called method

The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed.

NP_NULL_ON_SOME_PATH_EXCEPTION: Possible null pointer dereference in method on exception path

A reference value which is null on some exception control path is dereferenced here. This may lead to a NullPointerException when the code is executed. Note that because SpotBugs currently does not prune infeasible exception paths, this may be a false warning.

Also note that SpotBugs considers the default case of a switch statement to be an exception path, since the default case is often infeasible.

NP_TOSTRING_COULD_RETURN_NULL: toString method may return null

This toString method seems to return null in some circumstances. A liberal reading of the spec could be interpreted as allowing this, but it is probably a bad idea and could cause other code to break. Return the empty string or some other appropriate string rather than null.

NM_CLASS_NAMING_CONVENTION: Class names should start with an upper case letter

Class names should be nouns, in mixed case with the first letter of each internal word capitalized. Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations (unless the abbreviation is much more widely used than the long form, such as URL or HTML).

OBL_UNSATISFIED_OBLIGATION: Method may fail to clean up stream or resource

This method may fail to clean up (close, dispose of) a stream, database object, or other resource requiring an explicit cleanup operation.

In general, if a method opens a stream or other resource, the method should use a try/finally block to ensure that the stream or resource is cleaned up before the method returns.

This bug pattern is essentially the same as the OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE bug patterns, but is based on a different (and hopefully better) static analysis technique. We are interested is getting feedback about the usefulness of this bug pattern. For sending feedback, check:

In particular, the false-positive suppression heuristics for this bug pattern have not been extensively tuned, so reports about false positives are helpful to us.

See Weimer and Necula, Finding and Preventing Run-Time Error Handling Mistakes (PDF), for a description of the analysis technique.

OS_OPEN_STREAM: Method may fail to close stream

The method creates an IO stream object, does not assign it to any fields, pass it to other methods that might close it, or return it, and does not appear to close the stream on all paths out of the method. This may result in a file descriptor leak. It is generally a good idea to use a finally block to ensure that streams are closed.

RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE: Nullcheck of value previously dereferenced

A value is checked here to see whether it is null, but this value cannot be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous.

RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: Redundant nullcheck of value known to be non-null

This method contains a redundant check of a known non-null value against the constant null.

REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown

This method uses a try-catch block that catches Exception objects, but Exception is not thrown within the try block, and RuntimeException is not explicitly caught. It is a common bug pattern to say try { ... } catch (Exception e) { something } as a shorthand for catching a number of types of exception each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well, masking potential bugs.

A better approach is to either explicitly catch the specific exceptions that are thrown, or to explicitly catch RuntimeException exception, rethrow it, and then catch all non-Runtime Exceptions, as shown below:

try {
    ...
} catch (RuntimeException e) {
    throw e;
} catch (Exception e) {
    ... deal with all non-runtime exceptions ...
}

RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: Method ignores exceptional return value

This method returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. For example, the File.delete() method returns false if the file could not be successfully deleted (rather than throwing an Exception). If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value.

RV_NEGATING_RESULT_OF_COMPARETO: Negating the result of compareTo()/compare()

This code negates the return value of a compareTo or compare method. This is a questionable or bad programming practice, since if the return value is Integer.MIN_VALUE, negating the return value won't negate the sign of the result. You can achieve the same intended result by reversing the order of the operands rather than by negating the results.

RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side effect is ignored

This code calls a method and ignores the return value. However, our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus, this call can be removed.

We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include:

- The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis.

- The method is called to trigger the class loading which may have a side effect.

- The method is called just to get some exception.

If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct SpotBugs that ignoring the return value of this method is acceptable.

RpC_REPEATED_CONDITIONAL_TEST: Repeated conditional tests

The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0).

SA_LOCAL_DOUBLE_ASSIGNMENT: Double assignment of local variable

This method contains a double assignment of a local variable; e.g.

public void foo() {
    int x,y;
    x = x = 17;
}

Assigning the same value to a variable twice is useless, and may indicate a logic error or typo.

SBSC_USE_STRINGBUFFER_CONCATENATION: Method concatenates strings using + in a loop

The method seems to be building a String using concatenation in a loop. In each iteration, the String is converted to a StringBuffer/StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.

Better performance can be obtained by using a StringBuffer (or StringBuilder in Java 5) explicitly.

For example:

// This is bad
String s = "";
for (int i = 0; i < field.length; ++i) {
    s = s + field[i];
}

// This is better
StringBuffer buf = new StringBuffer();
for (int i = 0; i < field.length; ++i) {
    buf.append(field[i]);
}
String s = buf.toString();

SF_SWITCH_NO_DEFAULT: Switch statement found where default case is missing

This method contains a switch statement where default case is missing. Usually you need to provide a default case.

Because the analysis only looks at the generated bytecode, this warning can be incorrect triggered if the default case is at the end of the switch statement and the switch statement doesn't contain break statements for other cases.

SF_SWITCH_FALLTHROUGH: Switch statement found where one case falls through to the next case

This method contains a switch statement where one case branch will fall through to the next case. Usually you need to end this case with a break or return.

SIC_INNER_SHOULD_BE_STATIC: Should be a static inner class

This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.

SING_SINGLETON_IMPLEMENTS_SERIALIZABLE: Class using singleton design pattern directly or indirectly implements Serializable interface.

This class (using singleton design pattern) directly or indirectly implements the Serializable interface, which allows the class to be serialized.
Deserialization makes multiple instantiation of a singleton class possible, and therefore should be avoided.

SEI CERT MSC07-J rule

SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR: Class using singleton design pattern has non-private constructor.

This class is using singleton design pattern and has non-private constructor (please note that a default constructor might exist which is not private). Given that, it is possible to create a copy of the object, thus violating the singleton pattern.
The easier solution would be making the constructor private.

SEI CERT MSC07-J rule

SS_SHOULD_BE_STATIC: Unread field: should this field be static?

This class contains an instance final field that is initialized to a compile-time static value. Consider making the field static.

ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD: Write to static field from instance method

This instance method writes to a static field. This is tricky to get correct if multiple instances are being manipulated, and generally bad practice.

SWL_SLEEP_WITH_LOCK_HELD: Method calls Thread.sleep() with a lock held

This method calls Thread.sleep() with a lock held. This may result in very poor performance and scalability, or a deadlock, since other threads may be waiting to acquire the lock. It is a much better idea to call wait() on the lock, which releases the lock and allows other threads to run.

SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: Comparator doesn't implement Serializable

This class implements the Comparator interface. You should consider whether or not it should also implement the Serializable interface. If a comparator is used to construct an ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator is also serializable. As most comparators have little or no state, making them serializable is generally easy and good defensive programming.

SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class

A non-serializable value is stored into a non-transient field of a serializable class.

UC_USELESS_CONDITION: Condition has no effect

This condition always produces the same result as the value of the involved variable that was narrowed before. Probably something else was meant or the condition can be removed.

UC_USELESS_VOID_METHOD: Useless non-empty void method

Our analysis shows that this non-empty void method does not actually perform any useful work. Please check it: probably there's a mistake in its code or its body can be fully removed.

We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include:

The method is intended to trigger loading of some class which may have a side effect.
The method is intended to implicitly throw some obscure exception.

UC_USELESS_OBJECT: Useless object created

Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed.

This analysis rarely produces false-positives. Common false-positive cases include:

- This object used to implicitly throw some obscure exception.

- This object used as a stub to generalize the code.

- This object used to hold strong references to weak/soft-referenced objects.

SpotBugs Report

Project Information

Metrics

Contents

Summary

Warnings